feat: allow disabling cloudwatch logs for es #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmartingr
force-pushed
the
feat/es-disable-cloudwatch
branch
2 times, most recently
from
de42502 to
acc313f
Compare
Adds a new configuration option to allow disabling cloudwatch for ES in case it's not required or the credentials being used don't have the appropriate permissions.
fmartingr
force-pushed
the
feat/es-disable-cloudwatch
branch
from
acc313f to
ed78330
Compare
agnivade
approved these changes
Nov 27, 2024
agarciamontoro
approved these changes
Dec 2, 2024
Co-authored-by: Alejandro García Montoro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new configuration option to allow disabling cloudwatch for ES in case it's not required or the credentials being used don't have the appropriate permissions.
Also added an
aws_subnetblock to allow usage of ES without having to specify a subnet, since it was complaining:Ticket Link
https://mattermost.atlassian.net/browse/MM-61276