Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-58314] [MM-43784] Markdown and file preview in thread list #7963

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Boruus
Copy link

@Boruus Boruus commented May 21, 2024

Summary

Allowing markdown in thread list (for at mentions, links, and markdown tables) and add of file preview (for text, images, audio, video, pdf, etc).

Ticket Link

https://mattermost.atlassian.net/browse/MM-58314
https://mattermost.atlassian.net/browse/MM-43784

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on: iPhone 15 Pro, iOS 17.4

Screenshots

before after
image Capture d’écran 2024-05-21 à 09 13 35
image image

Release Note

Markdown and file preview in thread list

@mattermost-build
Copy link
Contributor

Hello @Boruus,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@Boruus
Copy link
Author

Boruus commented May 22, 2024

Hello @Boruus,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@marianunez
Copy link
Member

@Boruus thank you for your contribution. Can you sign the CLA? Seems that is still missing.

@marianunez marianunez added the 2: Dev Review Requires review by a core commiter label Aug 30, 2024
@marianunez marianunez requested review from larkox and enahum August 30, 2024 21:10
@larkox larkox added the 2: UX Review Requires review by a UX Designer label Sep 2, 2024
@larkox larkox requested a review from abhijit-singh September 2, 2024 08:12
@Boruus
Copy link
Author

Boruus commented Sep 3, 2024

@Boruus thank you for your contribution. Can you sign the CLA? Seems that is still missing.

Hi, sorry for my long response, i've already signed it for webapp mattermost, do I need to sign it again for mobile ?
image

@enahum
Copy link
Contributor

enahum commented Sep 3, 2024

/check-cla

@abhijit-singh abhijit-singh added the Build Apps for PR Build the mobile app for iOS and Android to test label Sep 4, 2024
@abhijit-singh
Copy link

@larkox Could you approve the workflow action here - https://github.com/mattermost/mattermost-mobile/actions/runs/10708019777?

@abhijit-singh abhijit-singh added Build Apps for PR Build the mobile app for iOS and Android to test and removed Build Apps for PR Build the mobile app for iOS and Android to test labels Sep 11, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@larkox
Copy link
Contributor

larkox commented Oct 28, 2024

I created this other branch to get the builds: #8293

Heads up @Boruus that I merged main into your branch.

@larkox
Copy link
Contributor

larkox commented Oct 28, 2024

@Boruus It seems your changes are breaking one test. Could you take a look at it? I think some changes have to be made to keep the previous behavior (but not 100% sure the previous behavior is the desired one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer Build Apps for PR Build the mobile app for iOS and Android to test Contributor Lifecycle/1:stale release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants