Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/deactivated users #8086

Closed
wants to merge 11 commits into from
Closed

Hide/deactivated users #8086

wants to merge 11 commits into from

Conversation

Juliet879
Copy link

@Juliet879 Juliet879 commented Jul 15, 2024

Summary
Remove deactivated users from being displayed in the 'Create Direct Message' screen in iOS mobile.

Device Information
iPhone 15 Pro

NONE

Simulator Screenshot - iPhone 15 Pro - 2024-07-15 at 12 36 39
Simulator Screenshot - iPhone 15 Pro - 2024-07-15 at 12 36 55

mattermost-build and others added 11 commits May 10, 2024 16:50
…) (#7947)

* host remove command, host removed feedback

* add view profile control

* i18n; dismissBottomSheet later

* PR comments

* remove confusing setPreviousCall(null)

* our own separator, bit more space for Android

* no need for previousCall due to changes on server

* move host removed alert to an error

* channel_id is not send via the msg.broadcast

* channel_id is still sent via the msg.broadcast

(cherry picked from commit 7fbd2e5)

Co-authored-by: Christopher Poile <[email protected]>
…7945) (#7948)

* add mute all to participant list

* i18n

* hostControlsAvailable

* mute-all -> mute-others

(cherry picked from commit 59db183)

Co-authored-by: Christopher Poile <[email protected]>
* Update README.md

* Update full_description.txt

* Update changelog

(cherry picked from commit 08c3825)

Co-authored-by: Amy Blais <[email protected]>
Co-authored-by: unified-ci-app[bot] <121569378+unified-ci-app[bot]@users.noreply.github.com>
)

(cherry picked from commit 663f9ba)

Co-authored-by: Daniel Espino García <[email protected]>
* Bump app build number to 529

* Bump app version number to 2.17.1

---------

Co-authored-by: runner <[email protected]>
@mattermost-build
Copy link
Contributor

Hello @Juliet879,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@enahum
Copy link
Contributor

enahum commented Jul 15, 2024

Many non related changes and is this removal of deactivated users actually expected?

@mm-cloud-bot
Copy link

@Juliet879: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants