Android native logs #8384
Merged
Android native logs #8384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
larkox
added
the
Do Not Merge/Awaiting PR
enahum
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
before merging this PR, we should update the library and remove this patch
larkox
removed
the
Do Not Merge/Awaiting PR
larkox
commented
Dec 10, 2024
| @@ -24,7 +24,7 @@ | |||
| "@mattermost/react-native-emm": "1.5.0", | |||
| "@mattermost/react-native-network-client": "1.7.3", | |||
| "@mattermost/react-native-paste-input": "0.8.0", | |||
| "@mattermost/react-native-turbo-log": "0.4.0", | |||
| "@mattermost/react-native-turbo-log": "github:mattermost/react-native-turbo-log#d8ddf5e7974546aff3e83b2c563907eb609ac5f4", | |||
There was a problem hiding this comment.
@enahum Let's use the github commit until we have the iOS version in place and we bump the version of the library.
|
@yasserfaraazkhan On a dev build, by defualt, the react native part won't create logs, so test this with a production build. The idea is that now you will have new logs, based on what happens on the native side (specially, when receiving notifications). Also, make sure that iOS has no relevant changes (no sudden crashes and the logs work just fine (just not the native part)). |
enahum
approved these changes
Dec 10, 2024
yasserfaraazkhan
added
the
Build App for Android
yasserfaraazkhan
approved these changes
Dec 12, 2024
larkox
added
QA Review Done
and removed
3: QA Review
|
going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add android Native Logs. IOS logs will be added in a later PR.
Related PR
mattermost/react-native-turbo-log#6
Ticket Link
Part of https://mattermost.atlassian.net/browse/MM-61970
Release Note