Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken windows #8406

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix broken windows #8406

wants to merge 3 commits into from
+29 −38

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Dec 10, 2024

Summary

  • Fixed resize image when Tablet screen is resized
  • Fixed the share feedback screen layout
  • Fixed the layout when there is an error with the playback of a video

Ticket Link

https://mattermost.atlassian.net/browse/MM-62043
https://mattermost.atlassian.net/browse/MM-61951
https://mattermost.atlassian.net/browse/MM-62100

Checklist

  • Added or updated unit tests (required for all new features)

Release Note

Fixed resize image when Tablet screen is resized
Fixed the share feedback screen layout
Fixed the layout when there is an error with the playback of a video

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Dec 10, 2024
@enahum enahum requested review from larkox and rahimrahman December 10, 2024 23:41
@enahum enahum added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core commiter labels Dec 12, 2024
@yasserfaraazkhan yasserfaraazkhan added the Build Apps for PR Build the mobile app for iOS and Android to test label Dec 12, 2024
@yasserfaraazkhan yasserfaraazkhan requested review from lindalumitchell and removed request for yasserfaraazkhan December 13, 2024 20:05
@yasserfaraazkhan
Copy link
Contributor

HI @lindalumitchell
I might need your help in testing this on iPad device. I'm out of office next week. I need you help in this one.
TIA. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahimrahman rahimrahman rahimrahman approved these changes

@larkox larkox larkox approved these changes

@lindalumitchell lindalumitchell Awaiting requested review from lindalumitchell

Assignees
No one assigned
Labels
3: QA Review Requires review by a QA tester Build Apps for PR Build the mobile app for iOS and Android to test release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enahum @yasserfaraazkhan @larkox @rahimrahman @mm-cloud-bot