Introduce ReadOnly property for form fields #165
Conversation
mickmister
added
2: Dev Review
| @@ -22,6 +23,14 @@ const ( | |||
|
|
|||
| // A mattermost channel reference (~name). | |||
| FieldTypeChannel FieldType = "channel" | |||
|
|
|||
| TextFieldSubtypeInput TextFieldSubtype = "input" | |||
There was a problem hiding this comment.
According to https://developers.mattermost.com/integrate/apps/interactivity/ the field is named text. Are the docs wrong?
There was a problem hiding this comment.
@hanzei The field type is text, but the text subtype can be any that are listed here: https://github.com/mattermost/mattermost-webapp/blob/74cbcb7c3f0dff7e21ecb88776b8841dd1fa55e6/components/widgets/settings/text_setting.tsx#L8
There was a problem hiding this comment.
It is already documented in the interactivity docs https://github.com/mattermost/mattermost-developer-documentation/blob/master/site/content/integrate/apps/interactivity/_index.md#modal-forms
There was a problem hiding this comment.
Yep, but it's documented as text there not input. Fixed in 3cda372 (#805)
There was a problem hiding this comment.
Tested and passed
- Tested using Michael's new autolink app Convert Autolink plugin into an App, and introduce autolink edit modal mattermost-community/mattermost-plugin-autolink#159
- Confirmed that read only fields are behaving as expected
- Tested on webapp and mobile to ensure client side support for both
- No issues found
LGTM!
DHaussermann
added
4: Reviews Complete
| @@ -22,6 +23,14 @@ const ( | |||
|
|
|||
| // A mattermost channel reference (~name). | |||
| FieldTypeChannel FieldType = "channel" | |||
|
|
|||
| TextFieldSubtypeInput TextFieldSubtype = "input" | |||
There was a problem hiding this comment.
Yep, but it's documented as text there not input. Fixed in 3cda372 (#805)
Summary
The
ReadOnlyfield is already supported by the webapp and mobile app. This PR adds the missingReadOnlyfield on the backend, as well as adding some constants for field types.Ticket Link
Related Pull Requests
mattermost-community/mattermost-plugin-autolink#159