Add restapi tests for stateful timers #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levb
approved these changes
Nov 10, 2022
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 20.15% 20.15%
=======================================
Files 80 80
Lines 6600 6600
=======================================
Hits 1330 1330
Misses 5138 5138
Partials 132 132 ☔ View full report in Codecov by Sentry. |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
mickmister
approved these changes
May 19, 2023
| assert.NoError(err) | ||
|
|
||
| // Check if callback was called | ||
| require.Eventually(th, func() bool { mut.Lock(); defer mut.Unlock(); return called }, 10*time.Second, 50*time.Millisecond) |
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add restapi tests for #375
Ticket Link
https://mattermost.atlassian.net/browse/MM-48342