Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.0 #415

Merged
merged 8 commits into from
Jan 6, 2023
Merged

Release v1.2.0 #415

merged 8 commits into from
Jan 6, 2023

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Dec 15, 2022

Summary

#380 is the past PR to go into the release before QA starts testing.

Ticket Link

Part of #378

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 15, 2022
@hanzei hanzei added this to the v1.2.0 milestone Dec 15, 2022
@hanzei hanzei requested a review from levb December 15, 2022 22:10
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Base: 20.90% // Head: 20.90% // No change to project coverage 👍

Coverage data is based on head (f760f9d) compared to base (5123678).
Patch has no changes to coverable lines.

❗ Current head f760f9d differs from pull request most recent head 5117cbf. Consider uploading reports for the commit 5117cbf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   20.90%   20.90%           
=======================================
  Files          80       80           
  Lines        5267     5267           
=======================================
  Hits         1101     1101           
  Misses       4037     4037           
  Partials      129      129           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei requested a review from DHaussermann December 16, 2022 08:40
@hanzei
Copy link
Contributor Author

hanzei commented Dec 16, 2022

Note to self: include changes from 0856d8f

@levb
Copy link
Contributor

levb commented Dec 16, 2022

Talked with @catalintomai, let's include servicenow (deprecated) as the "dummy" app to deploy the release with. cc: @hanzei , @DHaussermann , @mickmister

Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add servicenow (current version, that says deprecated) to the apps list?

@hanzei
Copy link
Contributor Author

hanzei commented Dec 16, 2022

@levb

"servicenow": "0.3.4"
?

@hanzei hanzei requested a review from levb December 16, 2022 19:23
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Dec 16, 2022
@hanzei
Copy link
Contributor Author

hanzei commented Jan 6, 2023

@DHaussermann The release is ready for your final review

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

Release testing summary posted here #378 (comment)

  • I have done a quick sanity check for a couple new commits.
  • Ensured new AWS bundle validate in appctl works
  • Ensured Zendesk 0.3.0 is in the manifest now.

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 6, 2023
@hanzei hanzei changed the title Release v1.2.0 Release v1.2.0 Jan 6, 2023
@hanzei hanzei enabled auto-merge (squash) January 6, 2023 21:53
@hanzei hanzei merged commit 44db542 into master Jan 6, 2023
@hanzei hanzei deleted the release_v1.2.0 branch January 6, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants