-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#25169 Apps Framework README > Split out admin content to child pages #481
Conversation
Hello @Reene-Simon, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #481 +/- ##
=======================================
Coverage 20.11% 20.11%
=======================================
Files 80 80
Lines 6628 6628
=======================================
Hits 1333 1333
Misses 5163 5163
Partials 132 132 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Reene-Simon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @Reene-Simon!
Please let me know your thoughts on my comment below pertaining to moving the content around a bit
@cwarnermm @mickmister I have made the requested changes. Please do review it. |
Approving assuming the above change is done |
@cwarnermm @mickmister I have made the relevant changes. Do check it out |
Summary
This PR organizes the README section as per the instructions in the issue description. I have used the reviews given for a similar issue, namely the Bitbucket README and have tried to incorporate the instructions given by the reviewers. These are the main changes that have been done:
Ticket Link
Fixes mattermost/mattermost#25169