-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow running a legal hold manually #129
base: main
Are you sure you want to change the base?
Conversation
… execution control
feat: Add reset status endpoint with five-click trigger for legal hold fix: Import Client in legal_hold_row.tsx to resolve ReferenceError
webapp/src/components/legal_hold_table/legal_hold_row/legal_hold_row.tsx
Show resolved
Hide resolved
/update-branch |
Error trying to update the PR. |
@fmartingr you'll have to update this PR with latest master. |
webapp/src/components/legal_hold_table/legal_hold_row/run_error_modal.tsx
Outdated
Show resolved
Hide resolved
webapp/src/components/legal_hold_table/legal_hold_row/reset_confirmation_modal.tsx
Outdated
Show resolved
Hide resolved
Should be up to date.
|
Requested re-review while I figure out what's wrong with playwright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for making changes 👍
@wiggin77 Fixed the problem with the e2e tests 2daf648 Unsure if this is the correct way to do it though, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment about the colours
I have made some changes to allow backwards comaptibility:
cc: @BenCookie95 @davidkrauser Not requesting a re-review, but feel free to do so. |
This pull request introduces new functionalities to manage and execute individual legal holds, along with corresponding tests and necessary refactoring. The most important changes include adding new API endpoints, implementing methods to run and reset legal holds, and updating the data model to include status tracking.
New API Endpoints:
server/api.go
.Methods for Legal Hold Management:
runSingleLegalHold
andresetLegalHoldStatus
methods inserver/api.go
to handle the new API endpoints.RunSingleLegalHold
method inserver/jobs/legal_hold_job.go
to execute a specific legal hold.Data Model Updates:
LegalHoldStatus
and added status tracking fields inserver/model/legal_hold.go
Interface and Refactoring:
LegalHoldJobInterface
to standardize the interface for legal hold jobs, facilitating easier testing and future enhancements inserver/jobs/legal_hold_job_interface.go
.Important changes
UI Changes
New button to refresh the legal hold list manually
Added a button to run a legal hold manually
Show when a current legal hold is running
Disable the run button if the legal hold is already running and the download button if there's no messages in the legal hold
Closes #90
Fixes #89