Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: end date not required when updating legal hold #58

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

fmartingr
Copy link
Contributor

Summary

Make the end date field not required to avoid validation errors when the form can be successfully submitted.

Closes #56

@mickmister
Copy link
Contributor

@fmartingr Does submitting an empty end date have any side effects?

@fmartingr
Copy link
Contributor Author

@fmartingr Does submitting an empty end date have any side effects?

AFAIK a legal hold with no end date is allowed by the backend, it means that the legal hold will be in place until manually released.

@mickmister
Copy link
Contributor

I'm not experiencing this issue on the master branch for some reason. This is working for me in the desktop app and in Arc browser. @fmartingr Were you able to reproduce the issue for creating this PR?

image

@fmartingr
Copy link
Contributor Author

fmartingr commented Jun 6, 2024

I'm not experiencing this issue on the master branch for some reason. This is working for me in the desktop app and in Arc browser. @fmartingr Were you able to reproduce the issue for creating this PR?

image

When I tested it the field was red, I don't remember now if the legal hold didn't had an end date or if I removed it myself, thus focusing the field and triggering the validation.

EDIT: Confirming that validation happens on focus/blur.

@fmartingr fmartingr merged commit 7988a77 into main Jun 10, 2024
4 checks passed
@fmartingr fmartingr deleted the fix/update-end-date branch June 10, 2024 05:53
@fmartingr fmartingr requested review from AayushChaudhary0001 and removed request for wiggin77 June 11, 2024 10:48
@fmartingr
Copy link
Contributor Author

@AayushChaudhary0001 can you add this to the QA pipeline please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a legal hold incorrectly states an end date is required
3 participants