[MM-339]: Added support for lower case meridiems(AM/PM) #438
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kshitij-Katiyar
added
2: Dev Review
wiggin77
reviewed
Nov 26, 2024
calendar/engine/daily_summary.go
Outdated
| @@ -291,3 +292,17 @@ func getTodayHoursForTimezone(now time.Time, timezone string) (start, end time.T | |||
| end = start.Add(24 * time.Hour) | |||
| return start, end | |||
| } | |||
|
|
|||
| func convertToUpperCaseTime(timeStr string) string { | |||
There was a problem hiding this comment.
Can we rename this to reflect that it is only changing the case for the meridiems?
There was a problem hiding this comment.
Sure, done @wiggin77 .
Updated it to convertMeridiemToUpperCase
raghavaggarwal2308
requested changes
Dec 2, 2024
raghavaggarwal2308
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for lowercase meridiems(AM/PM)
Ticket Link
Fixes #339
What to test
/mscalendar summary time 9:00AMand/mscalendar summary time 9:00am