Fix replica conn leak (#536)

server/plugin.go

@@ -397,7 +397,7 @@ func (p *Plugin) stop(isRestart bool) {
 	}
 
 	if !isRestart {
-		if err := p.store.Shutdown(); err != nil {
+		if err := p.apiClient.Store.Close(); err != nil {
 			p.API.LogError("failed to close db connection", "error", err)
 		}
 	}
@@ -578,7 +578,7 @@ func (p *Plugin) OnActivate() error {
 	if err := p.onActivate(); err != nil {
 		p.API.LogWarn("error activating the plugin", "error", err)
 		if p.store != nil {
-			if err = p.store.Shutdown(); err != nil {
+			if err = p.apiClient.Store.Close(); err != nil {
 				p.API.LogWarn("failed to close db connection", "error", err)
 			}
 		}

server/store/sqlstore/store.go

@@ -50,10 +50,6 @@ func New(db *sql.DB, api plugin.API, enabledTeams func() []string, encryptionKey
 	}
 }
 
-func (s *SQLStore) Shutdown() error {
-	return s.db.Close()
-}
-
 func (s *SQLStore) createTable(tableName, columnList string) error {
 	if _, err := s.db.Exec(fmt.Sprintf("CREATE TABLE IF NOT EXISTS %s (%s)", tableName, columnList)); err != nil {
 		return err

server/store/store.go

@@ -58,5 +58,4 @@ type Store interface {
 	IsUserPresentInWhitelist(userID string) (bool, error)
 	UpdateSubscriptionLastActivityAt(subscriptionID string, lastActivityAt time.Time) error
 	GetSubscriptionsLastActivityAt() (map[string]time.Time, error)
-	Shutdown() error
 }