-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add selective sync e2e testing from msteams to mattermost (#587)
- Loading branch information
Showing
1 changed file
with
311 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -274,3 +274,314 @@ func TestNewMSTeamsDirectMessage(t *testing.T) { | |
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestSelectiveSyncFromMsteams(t *testing.T) { | ||
| mattermost, store, mockClient, tearDown := containere2e.NewE2ETestPlugin(t) | ||
| defer tearDown() | ||
|
|
||
| adminClient, err := mattermost.GetAdminClient(context.Background()) | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.CreateUser(context.Background(), "[email protected]", "notconnected", "password") | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.CreateUser(context.Background(), "[email protected]", "mmprimary1", "password") | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.CreateUser(context.Background(), "[email protected]", "msteamsprimary1", "password") | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.CreateUser(context.Background(), "[email protected]", "mmprimary2", "password") | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.CreateUser(context.Background(), "[email protected]", "msteamsprimary2", "password") | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.CreateUser(context.Background(), "[email protected]", "msteams_synthetic1", "password") | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.CreateUser(context.Background(), "[email protected]", "msteams_synthetic2", "password") | ||
| require.NoError(t, err) | ||
|
|
||
| err = mattermost.AddUserToTeam(context.Background(), "notconnected", "test") | ||
| require.NoError(t, err) | ||
| err = mattermost.AddUserToTeam(context.Background(), "mmprimary1", "test") | ||
| require.NoError(t, err) | ||
| err = mattermost.AddUserToTeam(context.Background(), "msteamsprimary1", "test") | ||
| require.NoError(t, err) | ||
| err = mattermost.AddUserToTeam(context.Background(), "mmprimary2", "test") | ||
| require.NoError(t, err) | ||
| err = mattermost.AddUserToTeam(context.Background(), "msteamsprimary2", "test") | ||
| require.NoError(t, err) | ||
| err = mattermost.AddUserToTeam(context.Background(), "msteams_synthetic1", "test") | ||
| require.NoError(t, err) | ||
| err = mattermost.AddUserToTeam(context.Background(), "msteams_synthetic2", "test") | ||
| require.NoError(t, err) | ||
|
|
||
| notConnected, _, err := adminClient.GetUserByUsername(context.Background(), "notconnected", "") | ||
| require.NoError(t, err) | ||
| mmPrimary1, _, err := adminClient.GetUserByUsername(context.Background(), "mmprimary1", "") | ||
| require.NoError(t, err) | ||
| mmPrimary2, _, err := adminClient.GetUserByUsername(context.Background(), "mmprimary2", "") | ||
| require.NoError(t, err) | ||
| msteamsPrimary1, _, err := adminClient.GetUserByUsername(context.Background(), "msteamsprimary1", "") | ||
| require.NoError(t, err) | ||
| msteamsPrimary2, _, err := adminClient.GetUserByUsername(context.Background(), "msteamsprimary2", "") | ||
| require.NoError(t, err) | ||
| synthetic1, _, err := adminClient.GetUserByUsername(context.Background(), "msteams_synthetic1", "") | ||
| require.NoError(t, err) | ||
| synthetic2, _, err := adminClient.GetUserByUsername(context.Background(), "msteams_synthetic2", "") | ||
| require.NoError(t, err) | ||
|
|
||
| err = store.SetUserInfo(mmPrimary1.Id, "ms-mmprimary1", &fakeToken) | ||
| require.NoError(t, err) | ||
| setUserDefaultPlatform(t, mattermost, mmPrimary1, "mattermost") | ||
| err = store.SetUserInfo(mmPrimary2.Id, "ms-mmprimary2", &fakeToken) | ||
| require.NoError(t, err) | ||
| setUserDefaultPlatform(t, mattermost, mmPrimary2, "mattermost") | ||
| err = store.SetUserInfo(msteamsPrimary1.Id, "ms-msteamsprimary1", &fakeToken) | ||
| require.NoError(t, err) | ||
| setUserDefaultPlatform(t, mattermost, msteamsPrimary1, "msteams") | ||
| err = store.SetUserInfo(msteamsPrimary2.Id, "ms-msteamsprimary2", &fakeToken) | ||
| require.NoError(t, err) | ||
| setUserDefaultPlatform(t, mattermost, msteamsPrimary2, "msteams") | ||
| err = store.SetUserInfo(synthetic1.Id, "ms-msteams_synthetic1", nil) | ||
| require.NoError(t, err) | ||
| err = store.SetUserInfo(synthetic2.Id, "ms-msteams_synthetic2", nil) | ||
| require.NoError(t, err) | ||
|
|
||
| conn, err := mattermost.PostgresConnection(context.Background()) | ||
| require.NoError(t, err) | ||
| defer conn.Close() | ||
|
|
||
| // Mark users as synthetic | ||
| _, err = conn.Exec("UPDATE Users SET RemoteId = (SELECT remoteId FROM remoteclusters WHERE pluginid=$1) WHERE Username = 'msteams_synthetic1'", pluginID) | ||
| require.NoError(t, err) | ||
| _, err = conn.Exec("UPDATE Users SET RemoteId = (SELECT remoteId FROM remoteclusters WHERE pluginid=$1) WHERE Username = 'msteams_synthetic2'", pluginID) | ||
| require.NoError(t, err) | ||
|
|
||
| team, _, err := adminClient.GetTeamByName(context.Background(), "test", "") | ||
| require.NoError(t, err) | ||
|
|
||
| require.EventuallyWithT(t, func(c *assert.CollectT) { | ||
| suggestions, _, _ := adminClient.ListCommandAutocompleteSuggestions(context.Background(), "/msteams", team.Id) | ||
| assert.Len(c, suggestions, 1) | ||
| }, 10*time.Second, 500*time.Millisecond) | ||
|
|
||
| ttCases := []struct { | ||
| name string | ||
| fromUser *model.User | ||
| toUser *model.User | ||
| expectedWithSelectiveSync bool | ||
| expectedWithoutSelectiveSync bool | ||
| }{ | ||
| { | ||
| name: "from synthetic to not connected", | ||
| fromUser: synthetic1, | ||
| toUser: notConnected, | ||
| expectedWithSelectiveSync: false, | ||
| expectedWithoutSelectiveSync: false, | ||
| }, | ||
| { | ||
| name: "from synthetic to mmprimary", | ||
| fromUser: synthetic1, | ||
| toUser: mmPrimary1, | ||
| expectedWithSelectiveSync: true, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from synthetic to msteamsprimary", | ||
| fromUser: synthetic1, | ||
| toUser: msteamsPrimary1, | ||
| expectedWithSelectiveSync: false, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from mmprimary to not connected", | ||
| fromUser: mmPrimary1, | ||
| toUser: notConnected, | ||
| expectedWithSelectiveSync: false, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from mmprimary to mmprimary", | ||
| fromUser: mmPrimary1, | ||
| toUser: mmPrimary2, | ||
| expectedWithSelectiveSync: false, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from mmprimary to msteamsprimary", | ||
| fromUser: mmPrimary1, | ||
| toUser: msteamsPrimary1, | ||
| expectedWithSelectiveSync: true, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from mmprimary to synthetic", | ||
| fromUser: mmPrimary1, | ||
| toUser: synthetic2, | ||
| expectedWithSelectiveSync: true, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from msteamsprimary to not connected", | ||
| fromUser: msteamsPrimary1, | ||
| toUser: notConnected, | ||
| expectedWithSelectiveSync: true, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from msteamsprimary to mmprimary", | ||
| fromUser: msteamsPrimary1, | ||
| toUser: mmPrimary1, | ||
| expectedWithSelectiveSync: true, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from msteamsprimary to msteamsprimary", | ||
| fromUser: msteamsPrimary1, | ||
| toUser: msteamsPrimary2, | ||
| expectedWithSelectiveSync: false, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| { | ||
| name: "from msteamsprimary to synthetic", | ||
| fromUser: msteamsPrimary1, | ||
| toUser: synthetic2, | ||
| expectedWithSelectiveSync: false, | ||
| expectedWithoutSelectiveSync: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, enabledSelectiveSync := range []bool{false, true} { | ||
| config, _, err := adminClient.GetConfig(context.Background()) | ||
| require.NoError(t, err) | ||
| config.PluginSettings.Plugins[pluginID]["selectiveSync"] = enabledSelectiveSync | ||
| _, _, err = adminClient.UpdateConfig(context.Background(), config) | ||
| require.NoError(t, err) | ||
|
|
||
| name := "selective sync disabled" | ||
| if enabledSelectiveSync { | ||
| name = "selective sync enabled" | ||
| } | ||
|
|
||
| t.Run(name, func(t *testing.T) { | ||
| for _, tc := range ttCases { | ||
| var client *model.Client4 | ||
| var err error | ||
| if tc.fromUser.Id == synthetic1.Id { | ||
| client, err = mattermost.GetClient(context.Background(), tc.toUser.Username, "password") | ||
| } else { | ||
| client, err = mattermost.GetClient(context.Background(), tc.fromUser.Username, "password") | ||
| } | ||
| require.NoError(t, err) | ||
|
|
||
| dm, _, err := client.CreateDirectChannel(context.Background(), tc.fromUser.Id, tc.toUser.Id) | ||
| require.NoError(t, err) | ||
|
|
||
| msChannelID := model.NewId() | ||
| msMessageID := model.NewId() | ||
|
|
||
| require.NoError(t, mockClient.Reset()) | ||
|
|
||
| require.NoError(t, mockClient.Get("get-chat", "/v1.0/chats/"+msChannelID, map[string]any{ | ||
| "@odata.context": "https://graph.microsoft.com/v1.0/$metadata#chats/$entity", | ||
| "id": msChannelID, | ||
| "createdDateTime": time.Now().Format(time.RFC3339), | ||
| "lastUpdatedDateTime": time.Now().Format(time.RFC3339), | ||
| "chatType": "oneOnOne", | ||
| "tenantId": "tenant-id", | ||
| "members": []map[string]any{ | ||
| { | ||
| "@odata.type": "#microsoft.graph.aadUserConversationMember", | ||
| "id": model.NewId(), | ||
| "roles": []string{"owner"}, | ||
| "displayName": tc.fromUser.Username, | ||
| "userId": "ms-" + tc.fromUser.Username, | ||
| "email": tc.fromUser.Email, | ||
| "tenantId": "tenant-id", | ||
| }, | ||
| { | ||
| "@odata.type": "#microsoft.graph.aadUserConversationMember", | ||
| "id": model.NewId(), | ||
| "roles": []string{"owner"}, | ||
| "displayName": tc.toUser.Username, | ||
| "userId": "ms-" + tc.toUser.Username, | ||
| "email": tc.toUser.Email, | ||
| "tenantId": "tenant-id", | ||
| }, | ||
| }, | ||
| })) | ||
| require.NoError(t, mockClient.Get("get-user", "/v1.0/users/ms-"+tc.fromUser.Username, map[string]any{ | ||
| "displayName": tc.fromUser.Username, | ||
| "mail": tc.fromUser.Email, | ||
| "id": "ms-" + tc.fromUser.Username, | ||
| })) | ||
| require.NoError(t, mockClient.Get("get-other-user", "/v1.0/users/ms-"+tc.toUser.Username, map[string]any{ | ||
| "displayName": tc.toUser.Username, | ||
| "mail": tc.toUser.Email, | ||
| "id": "ms-" + tc.toUser.Username, | ||
| })) | ||
| require.NoError(t, mockClient.Get("get-message", "/v1.0/chats/"+msChannelID+"/messages/"+msMessageID, map[string]any{ | ||
| "@odata.context": "https://graph.microsoft.com/v1.0/$metadata#chats('" + msChannelID + "')/messages/$entity", | ||
| "id": msMessageID, | ||
| "etag": msMessageID, | ||
| "messageType": "message", | ||
| "createdDateTime": time.Now().Format(time.RFC3339), | ||
| "lastUpdatedDateTime": time.Now().Format(time.RFC3339), | ||
| "chatId": msChannelID, | ||
| "importance": "normal", | ||
| "locale": "en-us", | ||
| "from": map[string]any{ | ||
| "user": map[string]any{ | ||
| "@odata.type": "#microsoft.graph.teamworkUserIdentity", | ||
| "id": "ms-" + tc.fromUser.Username, | ||
| "displayName": tc.fromUser.Username, | ||
| "userIdentityType": "aadUser", | ||
| "tenantId": "tenant-id", | ||
| }, | ||
| }, | ||
| "body": map[string]any{ | ||
| "contentType": "text", | ||
| "content": name + " " + tc.name, | ||
| }, | ||
| })) | ||
|
|
||
| t.Run(tc.name, func(t *testing.T) { | ||
| err := sendActivity(t, client, msteams.Activity{ | ||
| Resource: "chats('" + msChannelID + "')/messages('" + msMessageID + "')", | ||
| ClientState: "webhook-secret", | ||
| ChangeType: "created", | ||
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| if enabledSelectiveSync && tc.expectedWithSelectiveSync || !enabledSelectiveSync && tc.expectedWithoutSelectiveSync { | ||
| require.EventuallyWithT(t, func(c *assert.CollectT) { | ||
| messages, _, err := client.GetPostsForChannel(context.Background(), dm.Id, 0, 1, "", false, false) | ||
| assert.NoError(c, err) | ||
| if assert.Len(c, messages.Order, 1) { | ||
| assert.Equal(c, name+" "+tc.name, messages.Posts[messages.Order[0]].Message) | ||
| // _, _ = client.DeletePost(context.Background(), messages.Order[0]) | ||
| } | ||
| }, 2*time.Second, 200*time.Millisecond) | ||
| } else { | ||
| require.Never(t, func() bool { | ||
| messages, _, err := client.GetPostsForChannel(context.Background(), dm.Id, 0, 1, "", false, false) | ||
| if err != nil { | ||
| return false | ||
| } | ||
| if len(messages.Order) != 1 { | ||
| return false | ||
| } | ||
| if messages.Posts[messages.Order[0]].Message != name+" "+tc.name { | ||
| return false | ||
| } | ||
| return true | ||
| }, 2*time.Second, 200*time.Millisecond) | ||
| } | ||
| }) | ||
| } | ||
| }) | ||
| } | ||
| } | ||