Skip to content
This repository has been archived by the owner on Jan 2, 2018. It is now read-only.

Charts with axis_labels do not display in gmail #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterkovacs
Copy link
Contributor

Displaying a chart in Gmail does not work with the current jstize function. It seems that Gmail chokes on unescaped | (pipe) characters for a labelled line chart, prefering the URL-encoded version. If jstize is replaced with URI.escape, then the chart renders correctly in Gmail.

The discussion for 9b5cfb9 makes it seem like this is intentional. However, URI.escape does not seem to break the display of any of the other example charts listed on http://googlecharts.rubyforge.org/

In order to properly handle escaping | for gmail, use URI.escape in jstize.
@hisham
Copy link

hisham commented Jul 20, 2011

Was this checked in? I see issue #27 (which is the same as this issue) in the code's comments:

# See http://github.com/mattetti/googlecharts/issues#issue/27
#URI.escape( string ).gsub("%7C", "|")

@peterkovacs
Copy link
Contributor Author

As far as I know it was never merged.

Edited: Ah, i screwed up when I made the issue. so I created this one to include the pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants