Fix checkstyle

matthias-ronge · Apr 12, 2024 · 58d8df9 · 58d8df9
1 parent 1c18fe1
commit 58d8df9
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 19 deletions.
diff --git a/Kitodo-DataManagement/src/main/java/org/kitodo/data/database/beans/Process.java b/Kitodo-DataManagement/src/main/java/org/kitodo/data/database/beans/Process.java
@@ -102,15 +102,22 @@ public class Process extends BaseTemplateBean implements ProcessInterface {
     private List<Comment> comments;
 
     @ManyToMany(cascade = CascadeType.ALL)
-    @JoinTable(name = "process_x_property", joinColumns = {@JoinColumn(name = "process_id", foreignKey = @ForeignKey(name = "FK_process_x_property_process_id")) }, inverseJoinColumns = {@JoinColumn(name = "property_id", foreignKey = @ForeignKey(name = "FK_process_x_property_property_id")) })
+    @JoinTable(name = "process_x_property", joinColumns = {
+        @JoinColumn(name = "process_id", foreignKey = @ForeignKey(name = "FK_process_x_property_process_id")) }, inverseJoinColumns = {
+            @JoinColumn(name = "property_id", foreignKey = @ForeignKey(name = "FK_process_x_property_property_id")) })
     private List<Property> properties;
 
     @ManyToMany(cascade = CascadeType.ALL)
-    @JoinTable(name = "template_x_property", joinColumns = {@JoinColumn(name = "process_id", foreignKey = @ForeignKey(name = "FK_template_x_property_process_id")) }, inverseJoinColumns = {@JoinColumn(name = "property_id", foreignKey = @ForeignKey(name = "FK_template_x_property_property_id")) })
+    @JoinTable(name = "template_x_property", joinColumns = {
+        @JoinColumn(name = "process_id", foreignKey = @ForeignKey(name = "FK_template_x_property_process_id")) }, inverseJoinColumns = {
+            @JoinColumn(name = "property_id", foreignKey = @ForeignKey(name = "FK_template_x_property_property_id")) })
     private List<Property> templates;
 
     @ManyToMany(cascade = CascadeType.ALL)
-    @JoinTable(name = "workpiece_x_property", joinColumns = {@JoinColumn(name = "process_id", foreignKey = @ForeignKey(name = "FK_workpiece_x_property_process_id")) }, inverseJoinColumns = {@JoinColumn(name = "property_id", foreignKey = @ForeignKey(name = "FK_workpiece_x_property_property_id")) })
+    @JoinTable(name = "workpiece_x_property", joinColumns = {
+        @JoinColumn(name = "process_id", foreignKey = @ForeignKey(name = "FK_workpiece_x_property_process_id")) },
+            inverseJoinColumns = {
+                @JoinColumn(name = "property_id", foreignKey = @ForeignKey(name = "FK_workpiece_x_property_property_id")) })
     private List<Property> workpieces;
 
     @ManyToMany(mappedBy = "processes")

diff --git a/Kitodo-DataManagement/src/main/java/org/kitodo/data/interfaces/TaskInterface.java b/Kitodo-DataManagement/src/main/java/org/kitodo/data/interfaces/TaskInterface.java
@@ -118,7 +118,7 @@ public interface TaskInterface extends DataInterface {
      * Sets the translated processing status of the task at runtime. This is a
      * transient value that is not persisted.
      *
-     * @param processingStatus
+     * @param processingStatusTitle
      *            translated processing status to set
      */
     void setProcessingStatusTitle(String processingStatusTitle);
@@ -164,10 +164,10 @@ public interface TaskInterface extends DataInterface {
     String getEditTypeTitle();
 
     /**
-     * Sets the translated processing tipe of the task at runtime. This is a
+     * Sets the translated processing type of the task at runtime. This is a
      * transient value that is not persisted.
      *
-     * @param processingStatus
+     * @param editTypeTitle
      *            translated processing type to set
      */
     void setEditTypeTitle(String editTypeTitle);
@@ -260,7 +260,7 @@ default String getProcessingBeginTime() {
      * Sets the time the task was accepted for processing. The string must be
      * parsable with {@link SimpleDateFormat}{@code ("yyyy-MM-dd HH:mm:ss")}.
      *
-     * @param processingTime
+     * @param processingBegin
      *            time to set
      * @throws ParseException
      *             if the time cannot be converted
@@ -274,7 +274,7 @@ default void setProcessingBeginTime(String processingBegin) throws ParseExceptio
     /**
      * Sets the time the task was accepted for processing.
      *
-     * @param processingTime
+     * @param processingBegin
      *            time to set
      */
     void setProcessingBegin(Date processingBegin);
@@ -317,7 +317,7 @@ default void setProcessingEndTime(String processingEnd) throws ParseException {
     /**
      * Sets the time the task was completed.
      *
-     * @param processingTime
+     * @param processingEnd
      *            time to set
      */
     void setProcessingEnd(Date processingEnd);
@@ -375,8 +375,8 @@ default void setProject(ProjectInterface project) {
      * Sets the production template this task belongs to. A task can only ever
      * be assigned to <i>either</i> a production template <i>or</i> a process.
      *
-     * @param process
-     *            process this task belongs to
+     * @param template
+     *            template this task belongs to
      */
     void setTemplate(TemplateInterface template);
 
@@ -420,7 +420,7 @@ default int getRolesSize() {
      * depends on, whether there are role objects in the database linked to the
      * process. No additional roles can be added to the process here.
      *
-     * @param size
+     * @param rolesSize
      *            how many users hold this role to set
      * @throws SecurityException
      *             when trying to assign unspecified roles to this process
@@ -589,9 +589,9 @@ default boolean isBatchAvailable() {
      * <dd>Corrections are pending.</dd>
      * </dl>
      * 
+     * @deprecated Use {@link getProces()}{@code .getCorrectionCommentStatus()}.
      * @return the status regarding corrections
      * @see org.kitodo.data.database.enums.CorrectionComments
-     * @deprecated Use {@link getProces()}{@code .getCorrectionCommentStatus()}.
      */
     @Deprecated
     default Integer getCorrectionCommentStatus() {

diff --git a/Kitodo-DataManagement/src/main/java/org/kitodo/data/interfaces/UserInterface.java b/Kitodo-DataManagement/src/main/java/org/kitodo/data/interfaces/UserInterface.java
@@ -195,7 +195,7 @@ default Integer getFiltersSize() {
      * whether there are filter objects in the database linked to the user. No
      * additional filters can be added to the process here.
      *
-     * @param size
+     * @param filtersSize
      *            how many users hold this role to set
      * @throws UnsupportedOperationException
      *             when trying to add unspecified filters to this user
@@ -253,7 +253,7 @@ default int getRolesSize() {
      * whether there are role objects in the database linked to the user. No
      * additional roles can be added to the user here.
      *
-     * @param size
+     * @param rolesSize
      *            number of roles to set
      * @throws SecurityException
      *             when trying to assign unspecified roles to this user
@@ -308,8 +308,8 @@ default int getClientsSize() {
      * whether there are role objects in the database linked to the user. No
      * additional roles can be added to the user here.
      *
-     * @param size
-     *            number of roles to set
+     * @param clientsSize
+     *            number of clients to set
      * @throws SecurityException
      *             when trying to assign unspecified roles to this user
      * @throws IndexOutOfBoundsException
@@ -363,8 +363,8 @@ default int getProjectsSize() {
      * whether there are role objects in the database linked to the user. No
      * additional roles can be added to the user here.
      *
-     * @param size
-     *            number of roles to set
+     * @param projectsSize
+     *            number of projects to set
      * @throws UnsupportedOperationException
      *             when trying to assign unspecified projects to this user
      * @throws IndexOutOfBoundsException