Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/8 sensitive data filter #9

Closed

Conversation

Toumash
Copy link

@Toumash Toumash commented Dec 3, 2021

Description: #8

Tomasz Dłuski added 2 commits December 3, 2021 19:06
@matthiasguentert matthiasguentert marked this pull request as ready for review December 7, 2021 08:07
Copy link
Owner

@matthiasguentert matthiasguentert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. I allowed myself to annotate some minor findings. What do you think?

@matthiasguentert matthiasguentert self-assigned this Dec 7, 2021
@lordscarlet
Copy link

Is there a plan to document how to use this and publish it to nuget?

@Toumash Toumash force-pushed the feature/8-sensitive-data-filter branch from 518f54e to aa1ca66 Compare March 20, 2022 16:54
Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs

Co-authored-by: Matthias Güntert <[email protected]>

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs

Co-authored-by: Matthias Güntert <[email protected]>

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/SensitiveDataFilter/SensitiveDataFilterTests.cs

Co-authored-by: Matthias Güntert <[email protected]>

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/BodyLoggerMiddlewareTests.cs

Co-authored-by: Matthias Güntert <[email protected]>

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/SensitiveDataFilter.cs

Co-authored-by: Matthias Güntert <[email protected]>

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/ISensitiveDataFilter.cs

Co-authored-by: Matthias Güntert <[email protected]>

fix build

^ This is the commit message matthiasguentert#2:

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs

Co-authored-by: Matthias Güntert <[email protected]>
^ This is the commit message matthiasguentert#3:

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/SensitiveDataFilter/SensitiveDataFilterTests.cs

Co-authored-by: Matthias Güntert <[email protected]>
^ This is the commit message matthiasguentert#4:

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/BodyLoggerMiddlewareTests.cs

Co-authored-by: Matthias Güntert <[email protected]>
# This is the commit message matthiasguentert#5:

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/BodyLoggerMiddlewareTests.cs

Co-authored-by: Matthias Güntert <[email protected]>
# This is the commit message matthiasguentert#6:

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/SensitiveDataFilter.cs

Co-authored-by: Matthias Güntert <[email protected]>
# This is the commit message matthiasguentert#7:

Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/ISensitiveDataFilter.cs

Co-authored-by: Matthias Güntert <[email protected]>
@Toumash Toumash force-pushed the feature/8-sensitive-data-filter branch from aa1ca66 to 7f0b2ec Compare March 20, 2022 16:55
Tomasz Dłuski added 2 commits March 20, 2022 17:57
# Conflicts:
#	ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Extensions/ServiceCollectionExtensions.cs
@ColinNg
Copy link
Contributor

ColinNg commented Feb 14, 2024

Is there a plan to document how to use this and publish it to nuget?

I haven't seen any activity in this repo, so in addition to the Pull Request #19, I've rebased the code and published it to NuGet as Azureblue.ApplicationInsights.RequestLogging-with-Sensitive-Data-Filter which I would be happy to take down if PR 19 gets approved/merged.

@matthiasguentert
Copy link
Owner

Is there a plan to document how to use this and publish it to nuget?

I haven't seen any activity in this repo, so in addition to the Pull Request #19, I've rebased the code and published it to NuGet as Azureblue.ApplicationInsights.RequestLogging-with-Sensitive-Data-Filter which I would be happy to take down if PR 19 gets approved/merged.

Dear @ColinNg, thanks a bunch for your contributions. I'll have a look this week and get back!

@Toumash
Copy link
Author

Toumash commented Feb 14, 2024

Closing this one then

@Toumash Toumash closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants