-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/8 sensitive data filter #9
Feature/8 sensitive data filter #9
Conversation
…l be leaked by logs
add sample creditCard data filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution. I allowed myself to annotate some minor findings. What do you think?
...icationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs
Outdated
Show resolved
Hide resolved
...icationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs
Outdated
Show resolved
Hide resolved
...tionInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/ISensitiveDataFilter.cs
Outdated
Show resolved
Hide resolved
...ationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/SensitiveDataFilter.cs
Outdated
Show resolved
Hide resolved
...gging/ApplicationInsightsRequestLoggingTests/SensitiveDataFilter/SensitiveDataFilterTests.cs
Outdated
Show resolved
Hide resolved
...onInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/BodyLoggerMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
Is there a plan to document how to use this and publish it to nuget? |
518f54e
to
aa1ca66
Compare
Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs Co-authored-by: Matthias Güntert <[email protected]> Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs Co-authored-by: Matthias Güntert <[email protected]> Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/SensitiveDataFilter/SensitiveDataFilterTests.cs Co-authored-by: Matthias Güntert <[email protected]> Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/BodyLoggerMiddlewareTests.cs Co-authored-by: Matthias Güntert <[email protected]> Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/SensitiveDataFilter.cs Co-authored-by: Matthias Güntert <[email protected]> Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/ISensitiveDataFilter.cs Co-authored-by: Matthias Güntert <[email protected]> fix build ^ This is the commit message matthiasguentert#2: Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Options/BodyLoggerOptions.cs Co-authored-by: Matthias Güntert <[email protected]> ^ This is the commit message matthiasguentert#3: Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/SensitiveDataFilter/SensitiveDataFilterTests.cs Co-authored-by: Matthias Güntert <[email protected]> ^ This is the commit message matthiasguentert#4: Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/BodyLoggerMiddlewareTests.cs Co-authored-by: Matthias Güntert <[email protected]> # This is the commit message matthiasguentert#5: Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLoggingTests/BodyLoggerMiddlewareTests.cs Co-authored-by: Matthias Güntert <[email protected]> # This is the commit message matthiasguentert#6: Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/SensitiveDataFilter.cs Co-authored-by: Matthias Güntert <[email protected]> # This is the commit message matthiasguentert#7: Update ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Filters/ISensitiveDataFilter.cs Co-authored-by: Matthias Güntert <[email protected]>
aa1ca66
to
7f0b2ec
Compare
# Conflicts: # ApplicationInsightsRequestLogging/ApplicationInsightsRequestLogging/Extensions/ServiceCollectionExtensions.cs
I haven't seen any activity in this repo, so in addition to the Pull Request #19, I've rebased the code and published it to NuGet as Azureblue.ApplicationInsights.RequestLogging-with-Sensitive-Data-Filter which I would be happy to take down if PR 19 gets approved/merged. |
Dear @ColinNg, thanks a bunch for your contributions. I'll have a look this week and get back! |
Closing this one then |
Description: #8