abstract lazy array for cart presenter + improvements

matthieu-rolland · Jul 19, 2024 · eae4e98 · eae4e98
1 parent fd52627
commit eae4e98
Show file tree

Hide file tree

Showing 2 changed files with 696 additions and 3 deletions.
diff --git a/src/Adapter/Presenter/AbstractLazyArray.php b/src/Adapter/Presenter/AbstractLazyArray.php
@@ -66,6 +66,8 @@
  */
 abstract class AbstractLazyArray implements Iterator, ArrayAccess, Countable, JsonSerializable
 {
+    private const INDEX_NAME_PATTERN = '/@indexName\s+"([^"]+)"/';
+
     /**
      * @var ArrayObject
      */
@@ -94,11 +96,17 @@ public function __construct()
         foreach ($methods as $method) {
             $methodDoc = $method->getDocComment();
             if (strpos($methodDoc, '@arrayAccess') !== false) {
+                if (preg_match(self::INDEX_NAME_PATTERN, $methodDoc, $matches)) {
+                    $indexName = $matches[1];
+                } else {
+                    $indexName = $this->convertMethodNameToIndex($method->getName());
+                }
                 $this->arrayAccessList->offsetSet(
-                    $this->convertMethodNameToIndex($method->getName()),
+                    $indexName,
                     [
                         'type' => 'method',
                         'value' => $method->getName(),
+                        'isRewritable' => strpos($methodDoc, '@isRewritable') !== false,
                     ]
                 );
             }
@@ -391,15 +399,17 @@ public function intersectKey($array)
      */
     public function offsetSet($offset, $value, $force = false): void
     {
-        if (!$force && $this->arrayAccessList->offsetExists($offset)) {
+        if ($this->arrayAccessList->offsetExists($offset)) {
             $result = $this->arrayAccessList->offsetGet($offset);
-            if ($result['type'] !== 'variable') {
+
+            if (!$force && $result['type'] !== 'variable' && !$result['isRewritable']) {
                 throw new RuntimeException('Trying to set the index ' . print_r($offset, true) . ' of the LazyArray ' . get_class($this) . ' already defined by a method is not allowed');
             }
         }
         $this->arrayAccessList->offsetSet($offset, [
             'type' => 'variable',
             'value' => $value,
+            'isRewritable' => $result['isRewritable'] ?? false,
         ]);
     }