idbp prototype & idb-plus wip #1505
ci.yaml
on: push
Typecheck
13s
Migrations
21s
Format & Lint (Biome)
14s
Format (Cargo)
17s
Clippy
2m 56s
Annotations
3 errors and 12 warnings
Format & Lint (Biome)
Process completed with exit code 1.
|
Typecheck
Process completed with exit code 1.
|
Migrations
Process completed with exit code 1.
|
Format & Lint (Biome)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Migrations
The following actions uses Node.js version which is deprecated and will be forced to run on node20: pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
unused variable: `final_cmd_id`:
crates/mx-windows/src/policies.rs#L19
warning: unused variable: `final_cmd_id`
--> crates/mx-windows/src/policies.rs:19:5
|
19 | final_cmd_id: CmdId,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_final_cmd_id`
|
= note: `#[warn(unused_variables)]` on by default
|
unused variable: `deploy_pk`:
crates/mx-windows/src/policies.rs#L50
warning: unused variable: `deploy_pk`
--> crates/mx-windows/src/policies.rs:50:39
|
50 | ManagementNode::Add { deploy_pk, value } => {
| ^^^^^^^^^ help: try ignoring the field: `deploy_pk: _`
|
unused variable: `deploy_pk`:
crates/mx-windows/src/policies.rs#L82
warning: unused variable: `deploy_pk`
--> crates/mx-windows/src/policies.rs:82:21
|
82 | deploy_pk, value, ..
| ^^^^^^^^^-
| |
| help: try removing the field
|
unused variable: `deploy_pk`:
crates/mx-windows/src/policies.rs#L263
warning: unused variable: `deploy_pk`
--> crates/mx-windows/src/policies.rs:263:55
|
263 | Some(ManagementNode::Delete { deploy_pk, value }) => {
| ^^^^^^^^^ help: try ignoring the field: `deploy_pk: _`
|
unused variable: `pending_deploy_statuses`:
crates/mx-windows/src/policies.rs#L180
warning: unused variable: `pending_deploy_statuses`
--> crates/mx-windows/src/policies.rs:180:5
|
180 | pending_deploy_statuses: Vec<GetPendingDeployStatusesResult>,
| ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pending_deploy_statuses`
|
useless conversion to the same type: `std::string::String`:
crates/mx-windows/src/policies.rs#L71
warning: useless conversion to the same type: `std::string::String`
--> crates/mx-windows/src/policies.rs:71:59
|
71 | ... DmValue::String(v) => v.into(),
| ^^^^^^^^ help: consider removing `.into()`: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
this `.filter_map` can be written more simply using `.map`:
crates/mx-windows/src/policies.rs#L194
warning: this `.filter_map` can be written more simply using `.map`
--> crates/mx-windows/src/policies.rs:194:26
|
194 | let policy_content = scoped_policies
| __________________________^
195 | | .into_iter()
196 | | .filter_map(|policy| {
197 | | // Note: If we skip stuff that doesn't change here we will have issues because another policy could change resulting in the c...
... |
212 | | Some((policy, latest, last, conflicts))
213 | | })
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
= note: `#[warn(clippy::unnecessary_filter_map)]` on by default
|
methods called `into_*` usually take `self` by value:
crates/mx-windows/src/policies.rs#L365
warning: methods called `into_*` usually take `self` by value
--> crates/mx-windows/src/policies.rs:365:23
|
365 | pub fn into_inner(&self) -> u64 {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
|
direct implementation of `ToString`:
crates/ms-ddf/src/ddf_v2.rs#L135
warning: direct implementation of `ToString`
--> crates/ms-ddf/src/ddf_v2.rs:135:1
|
135 | / impl ToString for DFFormatVariant {
136 | | fn to_string(&self) -> String {
137 | | match self {
138 | | DFFormatVariant::Base64 => "b64".to_string(),
... |
150 | | }
151 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
unused import: `ScopeVariant`:
apps/ingest/src/windows_ddf.rs#L7
warning: unused import: `ScopeVariant`
--> apps/ingest/src/windows_ddf.rs:7:73
|
7 | use ms_ddf::{AllowedValueGroupedNodes, DFFormatVariant, MgmtTree, Node, ScopeVariant};
| ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|