Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [skip ci] fix vulnerability in cross-spawn #82

Closed
wants to merge 2 commits into from
Closed

fix: [skip ci] fix vulnerability in cross-spawn #82

wants to merge 2 commits into from

Conversation

MargarytaKolomiyets
Copy link
Contributor

@MargarytaKolomiyets MargarytaKolomiyets commented Nov 29, 2024 •
edited
Loading

This replicates the security fix for cross-spawn open by Dependabot #79 and skips not-required CI checks.

security vulnerability ticket: https://mattrglobal.atlassian.net/browse/SEC-1112

Description

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

#

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@MargarytaKolomiyets MargarytaKolomiyets force-pushed the MK/fix-crossspawn-temp-skip-ci branch from de1a828 to 810f82e Compare November 29, 2024 01:34
@MargarytaKolomiyets MargarytaKolomiyets changed the title fix: skip ci fix vulnerability in cross-spawn fix: [skip ci[ fix vulnerability in crossspawn Nov 29, 2024
@MargarytaKolomiyets MargarytaKolomiyets changed the title fix: [skip ci[ fix vulnerability in crossspawn fix: [skip ci] fix vulnerability in crossspawn Nov 29, 2024
@MargarytaKolomiyets MargarytaKolomiyets changed the title fix: [skip ci] fix vulnerability in crossspawn fix: [skip ci] fix vulnerability in cross-spawn Nov 29, 2024
@MargarytaKolomiyets MargarytaKolomiyets changed the base branch from master to MK/ci-fixes December 1, 2024 19:42
@MargarytaKolomiyets MargarytaKolomiyets force-pushed the MK/ci-fixes branch 3 times, most recently from 4179d06 to 8047a62 Compare December 1, 2024 22:05
afonsobarracha
afonsobarracha previously approved these changes Dec 1, 2024
View reviewed changes
mate-from-mattr
mate-from-mattr previously approved these changes Dec 2, 2024
View reviewed changes
Base automatically changed from MK/ci-fixes to master December 2, 2024 01:05
@MargarytaKolomiyets MargarytaKolomiyets dismissed stale reviews from thomas-pearson-mattr, mate-from-mattr, and afonsobarracha December 2, 2024 01:05

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-pearson-mattr thomas-pearson-mattr thomas-pearson-mattr left review comments

@afonsobarracha afonsobarracha afonsobarracha left review comments

@mate-from-mattr mate-from-mattr mate-from-mattr left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MargarytaKolomiyets @mate-from-mattr @afonsobarracha @thomas-pearson-mattr