Skip to content

Commit

Permalink
feat!: Use new sap.ui.core.Lib from v1.120.0
Browse files Browse the repository at this point in the history
  • Loading branch information
mauriciolauffer committed Dec 5, 2023
1 parent 8a156bc commit 5a7a0dc
Show file tree
Hide file tree
Showing 17 changed files with 2,906 additions and 2,218 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
node-version: 20
registry-url: https://registry.npmjs.org
cache: npm
- run: npm i -g @ui5/cli --ignore-scripts
- run: npm ci --ignore-scripts
- run: npm run build
- run: npm publish --provenance
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_SECRET }}
134 changes: 134 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,137 @@ cp.project.properties.json
.project
.externalToolBuilders
tmp/
reports/

# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*
.pnpm-debug.log*

# Diagnostic reports (https://nodejs.org/api/report.html)
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage
*.lcov

# nyc test coverage
.nyc_output

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Snowpack dependency directory (https://snowpack.dev/)
web_modules/

# TypeScript cache
*.tsbuildinfo

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional stylelint cache
.stylelintcache

# Microbundle cache
.rpt2_cache/
.rts2_cache_cjs/
.rts2_cache_es/
.rts2_cache_umd/

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variable files
.env
.env.development.local
.env.test.local
.env.production.local
.env.local

# parcel-bundler cache (https://parceljs.org/)
.cache
.parcel-cache

# Next.js build output
.next
out

# Nuxt.js build / generate output
.nuxt

# Gatsby files
.cache/
# Comment in the public line in if your project uses Gatsby and not Next.js
# https://nextjs.org/blog/next-9-1#public-directory-support
# public

# vuepress build output
.vuepress/dist

# vuepress v2.x temp and cache directory
.temp
.cache

# Docusaurus cache and generated files
.docusaurus

# Serverless directories
.serverless/

# FuseBox cache
.fusebox/

# DynamoDB Local files
.dynamodb/

# TernJS port file
.tern-port

# Stores VSCode versions used for testing VSCode extensions
.vscode-test

# yarn v2
.yarn/cache
.yarn/unplugged
.yarn/build-state.yml
.yarn/install-state.gz
.pnp.*

target/
*.sarif
4 changes: 2 additions & 2 deletions demo/webapp/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
<div id="content" data-sap-ui-component data-async="true" data-id="mlauffer.demo"
data-name="mlauffer.demo.openui5.tour"></div>
<script id="sap-ui-bootstrap" async defer
src="https://openui5.hana.ondemand.com/1.96.0/resources/sap-ui-core.js"
data-sap-ui-libs="sap.m" data-sap-ui-theme="sap_fiori_3"
src="https://openui5.hana.ondemand.com/1.120.0/resources/sap-ui-core.js"
data-sap-ui-theme="sap_horizon"
data-sap-ui-compatVersion="edge" data-sap-ui-async="true"
data-sap-ui-oninit="module:sap/ui/core/ComponentSupport"
data-sap-ui-language="en"
Expand Down
10 changes: 5 additions & 5 deletions dist/resources/openui5/tour/library-dbg.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@
*/

sap.ui.define([
'sap/ui/core/Core',
'sap/ui/core/Lib',
'sap/ui/core/library',
'sap/m/library'
],
/**
* Module Dependencies
* @param {sap.ui.core.Core} Core - sap.ui.core.Core
* @returns {object|undefined} openui5.tour library
* @param {sap.ui.core.Lib} Lib - sap.ui.core.Lib
* @returns {object} openui5.tour library
*/
function(Core) {
function(Lib) {
/**
* OpenUI5 library: openui5.tour
* @namespace
Expand All @@ -25,7 +25,7 @@ function(Core) {
* @version 0.1.0
* @public
*/
return Core.initLibrary({
return Lib.init({
name: 'openui5.tour',
dependencies: [
'sap.ui.core',
Expand Down
4 changes: 2 additions & 2 deletions dist/resources/openui5/tour/library-preload.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/resources/openui5/tour/library-preload.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/resources/openui5/tour/library.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/resources/openui5/tour/library.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5a7a0dc

Please sign in to comment.