Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream, add some of the requested changes #1

Open
wants to merge 1,107 commits into
base: add-text-input-component
Choose a base branch
from

Conversation

EternityForest
Copy link

@EternityForest EternityForest commented Sep 2, 2023

I'm not sure if this one is useful, but I got it synced up to upstream. Not extensively tested, but perhaps it's a start?

Not sure if it matters, but the protobufs are compiled with 3.12 instead of 3.6, I can try to set up a VM and get the older version if it does matter.

  • Synced to upstream
  • Changed the message type numbers as the old ones conflicted with newer upstream work
  • Added the ability to persist strings to flash
  • Use this-> for property references instead of the implicit ones
  • add validate_ method(I wasn't quite sure what was actually needed or how validate works, more of a draft there, maybe @jesserockz can weigh in on if I did it right?)
  • Deleted commented out code that did not appear to be relevant
  • value_ begins at nullpointer by default(Not sure if that's actually a thing, or if the other components do it for a reason?)

HeMan and others added 30 commits August 17, 2023 12:22
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jesse Hills <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix 7789 clock mode and increase clock rate.

* Reverse change from dev.

* Speed up 8 bit color.

* Tweak buffer size
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
edwardtfn and others added 30 commits October 21, 2023 14:38
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jesse Hills <[email protected]>
Co-authored-by: orestismers <[email protected]>
Co-authored-by: Orestes Mersinias <[email protected]>
Co-authored-by: Jesse Hills <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fix setting pattern
Use max length for restore data length
Dont set initial_value as empty string
…changes

Dont publish empty string as initial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.