🐛 fix: update broken icon links for provider Devicon #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 fix: update Zend broken icon link
|
@algovoid is attempting to deploy a commit to the Mauro de Souza's projects Team on Vercel. A member of the Team first needs to authorize it. |
algovoid
changed the title
maurodesouza
requested changes
Sep 23, 2024
src/resources/tech_icons.ts
Outdated
Comment on lines
3887
to
3894
| devicons: { | ||
| path: 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/laravel/laravel-plain.svg', | ||
| path: 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/codepen/laravel-original.svg', | ||
| variants: [ | ||
| 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/laravel/laravel-plain.svg', | ||
| 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/laravel/laravel-plain-wordmark.svg', | ||
| 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/codepen/laravel-original.svg', | ||
| 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/codepen/laravel-original-wordmark.svg', | ||
| 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/codepen/laravel-line.svg', | ||
| 'https://cdn.jsdelivr.net/gh/devicons/devicon/icons/codepen/laravel-line-wordmark.svg', | ||
| ], |
There was a problem hiding this comment.
The Laravel icons are still broken, and it seems to be due to the prefix codepen/. All other links follow the pattern brand/brand-icon.svg.
I believe it should be laravel/laravel-original.svg.
Could you please update this? Thanks!
|
Hi @algovoid 👋 Sorry for the late response! I’ve reviewed your PR and noticed a minor issue with the Laravel icon links. Could you take a look at it? |
maurodesouza
approved these changes
Sep 23, 2024
|
Thanks @algovoid ❤ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What I did
updated broken links .