Snake case + bug fixes #835
Conversation
Fixing snake case with the help of camel-snake-pep8 (https://github.com/abarker/camel-snake-pep8)
|
I re-read some, and it may fail for some variable defined in thirdparty/ since I did not have changed variable names in this directory. |
|
Welcome @maxime-peim ! Thanks for spending your time in helping this project! I quickly checked the PR and it looks great! I would take a short time to recheck it but I will mege it ASAP. Regards, |
|
Hi @maurosoria ! |
|
Is that @jsfan🤣 |
|
@shelld3v Not this time. I've run out of different Github accounts to use. :P |
|
I am sorry to have created a duplicate. Since the point is explicitly asked in #672 and that I want to become familiar with the code, I was thinking that would be a great first contribution :P |
I appreciate that |
|
@maxime-peim I don't think it's a duplicate. I did part of this a while ago but haven't had a chance to finish it. So, thanks for taking it on. :) |
|
@maxime-peim Sorry because some changes were merged into your branch, those are updates that I want to do, but afraid that I might create some conflicts with your PR |
|
Don't worry, if you want I can solve possible conflicts :) |
|
Hey @maxime-peim, is there any way I can contact you (twitter or something)? |
|
Hi @shelld3v, you can contact me on discord at Maxou_#9933 ! |
|
Can I know a Discord server that you have joined? |
|
For sure, the Hack The Box one : HTB server |
|
Hey @maxime-peim, I am having problem when trying to DM you, can you try if you can DM me? |
|
@maxime-peim You can ping me in a channel, then click on that name and there will be several options including DM and send a friend request |
|
Do you use shelld3v as username ? Because I cannot found anybody called that way |
|
Yeah, shelld3v |
All is in the name, as asked in an issue, snake case is fixed in this PR. :)