Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

add generic analytics section for segment compatible api #323

Merged
merged 3 commits into from
Oct 9, 2023
Merged

add generic analytics section for segment compatible api #323

merged 3 commits into from
Oct 9, 2023

Conversation

the-newman
Copy link
Contributor

No description provided.

@the-newman the-newman force-pushed the segment-to-rudderstack branch from fc79eb2 to c140b8f Compare October 9, 2023 12:11
tulir
tulir reviewed Oct 9, 2023
View reviewed changes
mautrix_facebook/analytics.py Outdated Show resolved Hide resolved
tulir
tulir reviewed Oct 9, 2023
View reviewed changes
mautrix_facebook/analytics.py Outdated
import logging

from yarl import URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imports and type hint of analytics_url also need to be changed (github just isn't nice for suggestions across many places)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as soon as I pushed the commit suggestion I realised that would happen.

@the-newman the-newman force-pushed the segment-to-rudderstack branch from f007306 to ad29483 Compare October 9, 2023 15:20
@the-newman
Copy link
Contributor Author

Thanks for the review @tulir

@the-newman the-newman merged commit 72e0c83 into master Oct 9, 2023
5 checks passed
@the-newman the-newman deleted the segment-to-rudderstack branch October 9, 2023 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sumnerevans sumnerevans sumnerevans left review comments

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-newman @tulir @sumnerevans