Convert to NPM module #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrolfs
commented
Mar 25, 2016
•
jrolfs
commented
- CoffeeLint task (to be run as part of CI)
- Remove CommonJS conversion Ruby script
- Test against mavenlink-js
- Test against mavenlink
- Bug: Newly instantiated Brainstem Model instances are not stored in the StorageManager #71, PR: Cache newly fetched model references in storage manager #74
- Bug: Collection.fetch returns an array of models in the success callback instead of the collection instance #72, PR: Pass collection instance to fetch done callbacks #73
- Upgrade jasmine-core to 2.x - Use inflection npm dependency - Use brainstem-factory fork npm dependency - Ensure spec-helper and builders are evaluated before spec files - Add many missing dependencies to spec files
include monkey patch for Backbone's jQuery reference
Downgrade backbone
…_getExpectationName`
Add sourcemap support to karma config
|
|
||
| let karmaConfig = { | ||
| configFile: path.join(__dirname, 'karma.conf.js'), | ||
| singleRun: true, | ||
| sourceMaps: false |
There was a problem hiding this comment.
Don't we want source maps?
There was a problem hiding this comment.
This should be handled with the karma-source-maps-loader plugin now, I'll double check that this is not necessary.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.