camera: change API to support multiple cameras #352
Conversation
| /* | ||
| * Prepare the camera plugin (e.g. download the camera definition, etc). | ||
| */ | ||
| rpc Prepare(PrepareRequest) returns(PrepareResponse) {} |
There was a problem hiding this comment.
Why is this being removed? The idea was to be able to download the camera definition in advance, because it may be slow/timeout.
There was a problem hiding this comment.
My plan is to have it initialize automatically when it discovers a camera.
There was a problem hiding this comment.
Hmm... IIRC we've had issues in the past where is was being slow and either blocking stuff or producing a lot of timeouts. Then it was lazily initialized, but it caused issues because the very first call to a camera function was sometimes super slow (again, timeouts...).
Making it explicit has a few advantages:
- If you don't use the camera at all, you don't download the camera definition
- You can download the camera definition before you start using the camera (because usually you know in advance that you will use it)
There was a problem hiding this comment.
With C++ you would actually not even instantiate the plugin but I can see that for mavsdk_server it's a different story.
Beat added file caching for MAVSDK, so if we use that to cache the FTP file, it should be fairly quick actually.
There was a problem hiding this comment.
Your call 👍. I just wanted to mention why I added this function (in my experience the camera definition has always been the root of tons of camera problems)
There was a problem hiding this comment.
Right, I hear you. Let me try and see how it goes.
julianoes
force-pushed
the
pr-multiple-cameras
branch
from
5ef3a8b to
8e92f5f
Compare
julianoes
force-pushed
the
pr-multiple-cameras
branch
from
8e92f5f to
07f4c02
Compare
julianoes
force-pushed
the
pr-multiple-cameras
branch
from
07f4c02 to
4e59e5f
Compare
julianoes
force-pushed
the
pr-multiple-cameras
branch
from
4e59e5f to
11be846
Compare
julianoes
force-pushed
the
pr-multiple-cameras
branch
2 times, most recently
from
df0d4e4 to
82fb558
Compare
This changes the API to support more than one camera within one camera plugin instance. This will enable multiple cameras in language wrappers instead of just C++ as it is now. We also rename the status to storage because that's what it really is.
julianoes
force-pushed
the
pr-multiple-cameras
branch
from
829ac00 to
a6a536c
Compare
This changes the API to support more than one camera within one camera plugin instance.
This will enable multiple cameras in language wrappers instead of just C++ as it is now.