Add pure mode #1815
Draft
Add pure mode #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an API to set the compatibility_mode specifically to PX4, ArduPilot, or Pure. Pure is a new mode that should be based on common without any non-standard customizations.
In Pure mode we don't require this safety precaution.
The meaning of param4 has changed in the spec, so we have to update it.
PX4 currently requires the takeoff altitude as a parameter instead of the command param. This hopefully changes in the future. This commit changes the implementation slightly and also makes sure that the hack only exists for PX4 but not for ArduPilot or Pure mode.
According to the spec we could switch mode automatically when sending the DO_REPOSITION command. Therefore, for ArduPilot and Pure mode, we should actually use this. For PX4, we need to leave the hack which switches to Hold first, at least for the time being.
This excludes ORBIT from ArduPilot and Pure mode for now as it is still marked WIP. We need to decide if that's the right way to go forward, or if it should still be possible to use it in these compatibilitylmodes.
This is because ArduPilot would not work, and because it is not specced for Pure mode.
Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
pr-add-pure-mode
branch
from
2ed0b7a to
45c2e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work towards a MAVLink standard mode also called pure mode. It adds a setter for a
Systemto implement MAVLink according to the standard without PX4 or ArduPilot specific hacks.