Fix set param regression, improve param example #2480
Merged
+239
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out single params are sent with index -1, so caught by the test for the _HASH_CHECK param.
In case of a param set with the wrong type, we should catch that and return with wrong type.
It now morphs more into a param CLI tool.
JonasVautherin
previously approved these changes
Dec 19, 2024
This is required because GCC 9 and 10 don't implement std::from_chars for float yet.
julianoes
force-pushed
the
pr-param-fixes
branch
from
d7a19e0 to
6a6dcd8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.