This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Update index.js to allow custom configurations #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 7, 2017 20:07
function `electronOauth2(config, windowParams)` updated to allow custom options/query as an object. New: `electronOauth2(config, windowParams, customConfig)`
…-custom-config Updated index.js
Used single quotes for string instead of double quotes
|
Hello? Is this repository still being maintained? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified
electronOauth2(config, windowParams)and added a new parametercustomConfig. This argument accepts object. It is then used to append to the request url as query string. I made this request because some APIs require some additional parameters in order to request an authorization code.New: electronOauth2(config, windowParams, customConfig)