Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isoverse hexagon #258

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

add isoverse hexagon #258

wants to merge 2 commits into from

Conversation

sebkopf
Copy link

@sebkopf sebkopf commented Nov 6, 2019

hexagontruth
hexagontruth requested changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@hexagontruth hexagontruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. Both the SVG and PNG have alpha transparency on the image itself, on the main gray background at least. Not sure if this is intentional or not but it will certainly look weird on the site. Can you fix at least the PNG so it doesn't have this?
  2. Not a big deal and I would otherwise fix it myself but the raster and vector URLs are wrong. (Not sure why this can't be autopopulated but it is what it is.) Obvs see existing files for the format etc.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexagontruth hexagontruth hexagontruth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebkopf @hexagontruth