Skip to content

Commit

Permalink
Merge pull request #92 from maxisoft/91-missingmethodexception-method…
Browse files Browse the repository at this point in the history
…-not-found-void-systemiostreamreaderctorsystemiostream-systemtextencoding

Fix MissingMethodException with latest ASF update
  • Loading branch information
maxisoft authored Sep 9, 2024
2 parents 583ba7e + 5fb38fe commit 857c960
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ jobs:
if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') }}
needs: publish
runs-on: ubuntu-latest
permissions:
id-token: write
attestations: write

steps:
- name: Checkout code
Expand All @@ -183,6 +186,16 @@ jobs:
name: windows-latest_${{ env.PLUGIN_NAME }}-generic
path: out

- name: Unzip and copy generic artifact
run: |
mkdir -p attest_provenance
unzip out/${{ env.PLUGIN_NAME }}-generic.zip -d attest_provenance
cp --archive out/${{ env.PLUGIN_NAME }}-generic.zip attest_provenance
- uses: actions/attest-build-provenance@v1
with:
subject-path: 'attest_provenance/*'

- name: Create GitHub release
id: github_release
uses: actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion ASFFreeGames/HttpClientSimple/SimpleHttpClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public sealed class HttpStreamResponse(HttpResponseMessage response, Stream? str
public bool HasValidStream => stream is not null && (!EmptyStreamLazy.IsValueCreated || !ReferenceEquals(EmptyStreamLazy.Value, Stream));

public async Task<string> ReadAsStringAsync(CancellationToken cancellationToken) {
using StreamReader reader = new(Stream, Encoding.UTF8);
using StreamReader reader = new(Stream); // assume the encoding is UTF8, cannot be specified as per issue #91

return await reader.ReadToEndAsync(cancellationToken).ConfigureAwait(false);
}
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<PropertyGroup>
<PluginName>ASFFreeGames</PluginName>
<Version>1.6.1.0</Version>
<Version>1.6.2.0</Version>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

Expand Down

0 comments on commit 857c960

Please sign in to comment.