generated from JustArchiNET/ASF-PluginTemplate
-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redlib as alternative to reddit api #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as alternative to reddit
Minor changes here and there to disable explicit warning
# Conflicts: # ASFFreeGames/Reddit/RedditHelper.cs
Minor changes here and there to disable explicit warning
# Conflicts: # ASFFreeGames/Reddit/RedditHelper.cs
Use IReadOnlyCollection intead of ICollection on some part of the code
# Conflicts: # ASFFreeGames/Reddit/RedditHelper.cs
# Conflicts: # ASFFreeGames/Reddit/RedditHelper.cs
- Fix System.MissingMethodException in `games.RemoveAt((^1).GetOffset(games.Count));` - Code reformat
# Conflicts: # ASFFreeGames/Reddit/RedditHelper.cs
Ordered dict functionality support for trimmed asf binary
- integration test now can be activated by workflow_dispatch - use 7z to compress the 2 files before uploading them as artifact
…ostreamreaderctorsystemiostream-systemtextencoding' into dev
…ies, error handling, tests and update build process This commit introduces Redlib integration into the ASFFreeGames project, allowing it to fetch free games from Redlib instances. Key changes include: * **Redlib Integration:** * Added support for Redlib as a source for finding free games. * Implemented `RedlibListFreeGamesStrategy` to fetch games from Redlib instances. * Introduced configurations for Redlib proxy and instance URL. * Updated `ListFreeGamesMainStrategy` to handle fetching from Redlib as a fallback strategy. * **Code refactoring:** * Introduced `EListFreeGamesStrategy` enum to represent supported free game listing sources (Reddit, Redlib). * Improved logic for handling successful and failed attempts in `ListFreeGamesMainStrategy`. * Added exception handling for Redlib related issues. * **Testing:** * Added a new unit test (`RedlibInstanceListTests.Test`) to verify Redlib instance listing functionality. * Updated `FreeGamesCommand.Test` to handle Redlib strategy. * **Build:** * Added `Resouces` folder to the project. * Included `redlib_instances.json` as an embedded resource to store Redlib instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Redlib for free game discovery, add configurations, strategies, error handling, tests and update build process
This commit introduces Redlib integration into the ASFFreeGames project, allowing it to fetch free games from Redlib instances. Key changes include:
RedlibListFreeGamesStrategy
to fetch games from Redlib instances.ListFreeGamesMainStrategy
to handle fetching from Redlib as a fallback strategy.EListFreeGamesStrategy
enum to represent supported free game listing sources (Reddit, Redlib).ListFreeGamesMainStrategy
.RedlibInstanceListTests.Test
) to verify Redlib instance listing functionality.FreeGamesCommand.Test
to handle Redlib strategy.Resouces
folder to the project.redlib_instances.json
as an embedded resource to store Redlib instances.