Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MissingMethodException with latest ASF update #92

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Fix MissingMethodException with latest ASF update #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d8a342
Use StreamReader without specifying UTF8 encoding (as it's the defaul…
maxisoft Sep 9, 2024
5c5fd9e
Bump plugin version to 1.6.2
maxisoft Sep 9, 2024
5fb38fe
added attest-build-provenance in the ci
maxisoft Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ jobs:
if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') }}
needs: publish
runs-on: ubuntu-latest
permissions:
id-token: write
attestations: write

steps:
- name: Checkout code
Expand All @@ -183,6 +186,16 @@ jobs:
name: windows-latest_${{ env.PLUGIN_NAME }}-generic
path: out

- name: Unzip and copy generic artifact
run: |
mkdir -p attest_provenance
unzip out/${{ env.PLUGIN_NAME }}-generic.zip -d attest_provenance
cp --archive out/${{ env.PLUGIN_NAME }}-generic.zip attest_provenance

- uses: actions/attest-build-provenance@v1
with:
subject-path: 'attest_provenance/*'

- name: Create GitHub release
id: github_release
uses: actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion ASFFreeGames/HttpClientSimple/SimpleHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public sealed class HttpStreamResponse(HttpResponseMessage response, Stream? str
public bool HasValidStream => stream is not null && (!EmptyStreamLazy.IsValueCreated || !ReferenceEquals(EmptyStreamLazy.Value, Stream));

public async Task<string> ReadAsStringAsync(CancellationToken cancellationToken) {
using StreamReader reader = new(Stream, Encoding.UTF8);
using StreamReader reader = new(Stream); // assume the encoding is UTF8, cannot be specified as per issue #91

return await reader.ReadToEndAsync(cancellationToken).ConfigureAwait(false);
}
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<PropertyGroup>
<PluginName>ASFFreeGames</PluginName>
<Version>1.6.1.0</Version>
<Version>1.6.2.0</Version>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

Expand Down
Loading