Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: core startup fails if /opt/mailman/mailman-extra.cfg is read-only #718

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

pgmillon
Copy link
Contributor

@pgmillon pgmillon commented Aug 29, 2024

Follow-up to #86, after studying the content of /opt/mailman, only the var sub-folder seems important as writable.

@maxking
Copy link
Owner

maxking commented Aug 30, 2024

Thanks for the fix, LGTM! Yes, Mailman really only needs to write inside the /var directory.

@maxking maxking enabled auto-merge August 30, 2024 03:57
@pgmillon
Copy link
Contributor Author

I don't know why but for some reason CircleCI doesn't trigger 🤔

@maxking maxking closed this Aug 30, 2024
auto-merge was automatically disabled August 30, 2024 06:37

Pull request was closed

@maxking maxking reopened this Aug 30, 2024
@maxking
Copy link
Owner

maxking commented Aug 30, 2024

I am investigating that, somehow this PR didn't trigger circleci but few before this did.

@maxking maxking merged commit 4fee322 into maxking:main Aug 31, 2024
@maxking
Copy link
Owner

maxking commented Aug 31, 2024

Ok, now the tests ran when it got merged with main and is failing. The reason is mostly that var may not exist during first startup since it is created only after mailman starts.

We might be able to pre-create a var directory and have Mailman use it (idk if it will complain about sub-directories missing or will just create it - we can try it out though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants