Sromani/improve docs #152
Merged
Sromani/improve docs #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadromani
force-pushed
the
sromani/improve-docs
branch
from
f2a792b
to
e5500b4
Compare
oschwald
requested changes
Jan 23, 2024
| @@ -5,6 +5,8 @@ | |||
| /** | |||
| * DatabaseRecord represents the data and metadata associated with a database | |||
| * lookup. | |||
| * | |||
| * @param <T> the type of data stored at the node | |||
There was a problem hiding this comment.
I think for these, something more like "the type to deserialize the returned value to" would be more accurate.
shadromani
force-pushed
the
sromani/improve-docs
branch
from
a5230a0
to
dbe1e8f
Compare
oschwald
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.