Merge pull request #164 from maxmind/horgh/email-normalize-fix

Fix issue where local part was changed incorrectly in hashEmail heuristics
maxmind · Mar 4, 2024 · 26e43ea · 26e43ea
2 parents 150fb00 + ba46594
commit 26e43ea
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/MinFraud/Util.php b/src/MinFraud/Util.php
@@ -305,9 +305,9 @@ private static function hashEmail(string $localPart, string $domain): string
             $possibleDomain = implode('.', \array_slice($domainParts, 1));
             if (isset(self::$fastmailDomains[$possibleDomain])) {
                 $domain = $possibleDomain;
-            }
-            if ($localPart !== '') {
-                $localPart = $domainParts[0];
+                if ($localPart !== '') {
+                    $localPart = $domainParts[0];
+                }
             }
         }
 

diff --git a/tests/MaxMind/Test/MinFraud/UtilTest.php b/tests/MaxMind/Test/MinFraud/UtilTest.php
@@ -188,6 +188,16 @@ public function testMaybeHashEmail(): void
                     ],
                 ],
             ],
+            [
+                'name' => 'Domain with multiple host parts',
+                'input' => ['email' => ['address' => '[email protected]']],
+                'expected' => [
+                    'email' => [
+                        'address' => md5('[email protected]'),
+                        'domain' => 'bar.example.com',
+                    ],
+                ],
+            ],
             [
                 'name' => 'Yahoo domain',
                 'input' => ['email' => ['address' => '[email protected]']],