fix: default value set to true causes undefined method [] error #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinesaliba
commented
Jul 3, 2024
| include ActsAsComparable | ||
|
|
||
| const :tired, T::Boolean, default: false | ||
| end |
There was a problem hiding this comment.
I debated just adding something to the job struct but it makes me nervous to keep adding things to that test struct because it's not easy to understand that every piece in there tests a number of things. I decided to just be more explicit and just create structs for specific testcases, this way we don't have one or a few central structs that hold everything together. Thoughts?
There was a problem hiding this comment.
Yea I think this is fine for testing a specific case.
maxveldink
approved these changes
Jul 5, 2024
| include ActsAsComparable | ||
|
|
||
| const :tired, T::Boolean, default: false | ||
| end |
There was a problem hiding this comment.
Yea I think this is fine for testing a specific case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug hidden by another partial bug. The hidden bug is here and it's just that it needs kwargs name and value. The bug that hid it was that the
field.defaultcheck in the conditionalif value.nil? && field.defaultwill return false when the default value is false and it just so happened to be that our test struct defaults to false so line 39 was never tested.