forked from emikulic/darkhttpd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Pull Request #2
Open
andrewwchong
wants to merge
14
commits into
mayhemheroes:master
Choose a base branch
from
andrewwchong:mayhem
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing I would change is to make sure that you aren't overwriting the upstream's Dockerfile. I would:
|
Please update this PR or we will have to close it. |
xansec
requested changes
May 29, 2022
@@ -1,16 +1,37 @@ | |||
# Build environment | |||
FROM alpine AS build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't overwrite upstream's Dockerfile
mayhem-bot
force-pushed
the
master
branch
2 times, most recently
from
October 8, 2022 14:00
a923429
to
a9d274a
Compare
mayhem-bot
force-pushed
the
master
branch
2 times, most recently
from
December 12, 2022 15:00
e468202
to
ea9560b
Compare
mayhem-bot
force-pushed
the
master
branch
2 times, most recently
from
January 19, 2024 07:09
2bfa72f
to
d1992a8
Compare
mayhem-bot
force-pushed
the
master
branch
5 times, most recently
from
March 5, 2024 07:40
d4d8ae7
to
189552e
Compare
mayhem-bot
force-pushed
the
master
branch
4 times, most recently
from
March 13, 2024 07:09
f330e25
to
d5b3a43
Compare
mayhem-bot
force-pushed
the
master
branch
2 times, most recently
from
March 23, 2024 07:07
641dad7
to
e43d423
Compare
mayhem-bot
force-pushed
the
master
branch
2 times, most recently
from
June 1, 2024 07:13
8447421
to
9932db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I opened a pull request with the wrong branch! Let me know if there is anything else I need to fix.