Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pull Request #2

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

andrewwchong
Copy link

Sorry, I opened a pull request with the wrong branch! Let me know if there is anything else I need to fix.

@xansec
Copy link
Collaborator

xansec commented May 15, 2022

The only thing I would change is to make sure that you aren't overwriting the upstream's Dockerfile. I would:

  1. Restore the upstream Dockerfile
  2. Create a Dockerfile.mayhem
  3. Set the Docker bulid action to use this file, i.e.:
- name: Build and push Docker image
      uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
      with:
        context: .
        push: true
        tags: ${{ steps.meta.outputs.tags }}
        labels: ${{ steps.meta.outputs.labels }}
        file: <name or path to my custom Dockerfile>

@xansec
Copy link
Collaborator

xansec commented May 29, 2022

Please update this PR or we will have to close it.

@@ -1,16 +1,37 @@
# Build environment
FROM alpine AS build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't overwrite upstream's Dockerfile

@mayhem-bot mayhem-bot force-pushed the master branch 2 times, most recently from a923429 to a9d274a Compare October 8, 2022 14:00
@mayhem-bot mayhem-bot force-pushed the master branch 2 times, most recently from e468202 to ea9560b Compare December 12, 2022 15:00
@mayhem-bot mayhem-bot force-pushed the master branch 2 times, most recently from 2bfa72f to d1992a8 Compare January 19, 2024 07:09
@mayhem-bot mayhem-bot force-pushed the master branch 5 times, most recently from d4d8ae7 to 189552e Compare March 5, 2024 07:40
@mayhem-bot mayhem-bot force-pushed the master branch 4 times, most recently from f330e25 to d5b3a43 Compare March 13, 2024 07:09
@mayhem-bot mayhem-bot force-pushed the master branch 2 times, most recently from 641dad7 to e43d423 Compare March 23, 2024 07:07
@mayhem-bot mayhem-bot force-pushed the master branch 2 times, most recently from 8447421 to 9932db3 Compare June 1, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants