macosx: Fix switch case and return warnings in VLCLibrarySegment

Signed-off-by: Claudio Cambra <[email protected]>

modules/gui/macosx/library/VLCLibrarySegment.m

@@ -219,7 +219,7 @@ - (NSString *)displayStringForType:(VLCLibrarySegmentType)segmentType
             NSAssert(NO, @"displayStringForType should not be called for this segment type");
         case VLCLibraryLowSentinelSegment:
         case VLCLibraryHighSentinelSegment:
-            NSAssert(true, @"Invalid segment value");
+            NSAssert(NO, @"Invalid segment value");
     }
     return nil;
 }
@@ -256,7 +256,13 @@ - (NSImage *)oldIconImageForType:(VLCLibrarySegmentType)segmentType
         case VLCLibraryGroupsSegment:
         case VLCLibraryGroupsGroupSubSegment:
             return [NSImage imageNamed:@"NSTouchBarTagIcon"];
+        case VLCLibraryLowSentinelSegment:
+        case VLCLibraryHighSentinelSegment:
+            NSAssert(NO, @"Invalid segment value");
+            return nil;
     }
+
+    return nil;
 }
 
 - (NSImage *)newIconImageForType:(VLCLibrarySegmentType)segmentType
@@ -316,10 +322,13 @@ - (NSImage *)newIconImageForType:(VLCLibrarySegmentType)segmentType
         case VLCLibraryGroupsGroupSubSegment:
             return [NSImage imageWithSystemSymbolName:@"play.rectangle"
                              accessibilityDescription:@"Group icon"];
+        case VLCLibraryLowSentinelSegment:
+        case VLCLibraryHighSentinelSegment:
+            NSAssert(NO, @"Invalid segment value");
+            return nil;
         }
-    } else {
-        return nil;
     }
+    return nil;
 }
 
 - (NSImage *)iconForType:(VLCLibrarySegmentType)segmentType