Skip to content

Commit

Permalink
qt: reduce playlist delegate vertical padding
Browse files Browse the repository at this point in the history
Although having excessive padding makes it possible
to interact with the delegate using touch control
easier, it also causes the playlist to show less
items at once.

VLC is primarily a desktop application, although
we should care about touch support, we should not
optimize the design for touch.

Reducing the vertical padding from 6dp to 2dp seems
to be good compromise. It is still very much possible
to use touch, but also looks okay for a desktop
application.
  • Loading branch information
fuzun authored and fkuehne committed Oct 27, 2024
1 parent 0e4be11 commit a6f78e7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion modules/gui/qt/playlist/qml/PlaylistDelegate.qml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ T.Control {

hoverEnabled: true

verticalPadding: VLCStyle.playlistDelegate_verticalPadding
verticalPadding: VLCStyle.margin_xxxsmall

leftPadding: VLCStyle.margin_normal

Expand Down
2 changes: 0 additions & 2 deletions modules/gui/qt/style/VLCStyle.qml
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,6 @@ QtObject {

readonly property int artistBanner_height: MainCtx.dp(200, scale)

readonly property int playlistDelegate_verticalPadding: MainCtx.dp(6, scale)

//global application size, updated by the root widget
property int appWidth: 0
property int appHeight: 0
Expand Down

0 comments on commit a6f78e7

Please sign in to comment.