Skip to content

Commit

Permalink
macosx: Fix crash upon dealloc of VLCLibraryWindow
Browse files Browse the repository at this point in the history
Caused by trying to remove KVO when none was added

Signed-off-by: Claudio Cambra <[email protected]>
  • Loading branch information
claucambra authored and robUx4 committed Oct 9, 2024
1 parent d3c65e6 commit d22daeb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions modules/gui/macosx/library/VLCLibraryWindow.m
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,6 @@ - (void)awakeFromNib
- (void)dealloc
{
[NSNotificationCenter.defaultCenter removeObserver:self];
if (@available(macOS 10.14, *)) {
[NSApplication.sharedApplication removeObserver:self forKeyPath:@"effectiveAppearance"];
}

libvlc_int_t *libvlc = vlc_object_instance(getIntf());
var_DelCallback(libvlc, "intf-toggle-fscontrol", ShowFullscreenController, (__bridge void *)self);
var_DelCallback(libvlc, "intf-show", ShowController, (__bridge void *)self);
Expand Down

0 comments on commit d22daeb

Please sign in to comment.