Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flush command #29

Merged
merged 3 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Changelog = "https://github.com/maykinmedia/django-timeline-logger/blob/master/d
[project.optional-dependencies]
tests = [
"factory-boy",
"time-machine",
"psycopg2",
"pytest",
"pytest-cov",
Expand Down
51 changes: 49 additions & 2 deletions tests/test_management_commands.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from datetime import timedelta
from datetime import datetime, timedelta, timezone as dt_timezone
from io import StringIO

from django.conf import settings
from django.core import mail
Expand All @@ -7,13 +8,16 @@
from django.test import TestCase, override_settings
from django.utils import timezone

import time_machine

from timeline_logger.models import TimelineLog

from .factories import ArticleFactory, UserFactory
from .factories import ArticleFactory, TimelineLogFactory, UserFactory


class ReportMailingTestCase(TestCase):
def setUp(self):
super().setUp()
self.article = ArticleFactory.create()

self.user = UserFactory.create(email="[email protected]")
Expand Down Expand Up @@ -152,3 +156,46 @@ def test_timeline_digest_from_email_setting(self):

self.assertEqual(len(mail.outbox), 1)
self.assertEqual(mail.outbox[0].from_email, settings.TIMELINE_DIGEST_FROM_EMAIL)


@time_machine.travel(datetime(2024, 3, 5, 0, 0, 0, tzinfo=dt_timezone.utc))
class PruneTimelineLogsTestCase(TestCase):
def setUp(self):
super().setUp()

self.log_1 = TimelineLogFactory.create()
self.log_1.timestamp = datetime(2024, 3, 1, 0, 0, 0, tzinfo=dt_timezone.utc)
self.log_1.save()

self.log_2 = TimelineLogFactory.create()
self.log_2.timestamp = datetime(2024, 3, 4, 0, 0, 0, tzinfo=dt_timezone.utc)
self.log_2.save()

def test_prune_timeline_logs_no_date(self):
stdout = StringIO()

call_command(
"prune_timeline_logs",
"--all",
interactive=False,
verbosity=0,
stdout=stdout,
)

self.assertEqual(TimelineLog.objects.count(), 0)
self.assertEqual(
stdout.getvalue().strip(), "Successfully deleted 2 timeline logs."
)

def test_prune_timeline_logs_date(self):
call_command(
"prune_timeline_logs",
"--keep-days",
"2",
interactive=False,
verbosity=0,
stdout=StringIO(),
)

self.assertEqual(TimelineLog.objects.count(), 1)
self.assertEqual(TimelineLog.objects.first().pk, self.log_2.pk)
54 changes: 54 additions & 0 deletions timeline_logger/management/commands/prune_timeline_logs.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
from textwrap import dedent

from django.core.management.base import BaseCommand

from timeline_logger.service import prune_timeline_logs


class Command(BaseCommand):
help = "Removes timeline logs objects older than the specified date."

def add_arguments(self, parser):
parser.add_argument(
"--noinput",
"--no-input",
action="store_false",
dest="interactive",
help="Tells Django to NOT prompt the user for input of any kind.",
)
exclusive_group = parser.add_mutually_exclusive_group(required=True)

exclusive_group.add_argument(
"--all",
action="store_true",
help="Whether to delete all log records.",
)

exclusive_group.add_argument(
"--keep-days",
type=int,
help="Only delete records older than the specified number of days.",
)

def handle(self, *args, **options):
Viicos marked this conversation as resolved.
Show resolved Hide resolved
all = options["all"]
keep_days = options["keep_days"]
interactive = options["interactive"]

if all and interactive:
confirm = input(

Check warning on line 39 in timeline_logger/management/commands/prune_timeline_logs.py

View check run for this annotation

Codecov / codecov/patch

timeline_logger/management/commands/prune_timeline_logs.py#L39

Added line #L39 was not covered by tests
dedent(
"""You have specified "--all", meaning all timeline logs will be deleted.
Are you sure you want to do this?

Type 'yes' to continue, or 'no' to cancel: """
)
)
else:
confirm = "yes"

if confirm == "yes":
number = prune_timeline_logs(keep_days=0 if all else keep_days)
self.stdout.write(f"Successfully deleted {number} timeline logs.")
else:
self.stdout.write("Flush cancelled.")

Check warning on line 54 in timeline_logger/management/commands/prune_timeline_logs.py

View check run for this annotation

Codecov / codecov/patch

timeline_logger/management/commands/prune_timeline_logs.py#L54

Added line #L54 was not covered by tests
19 changes: 19 additions & 0 deletions timeline_logger/service.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from datetime import timedelta

from django.utils import timezone

from .models import TimelineLog


def prune_timeline_logs(*, keep_days: int | None = None) -> int:
"""Delete the timeline logs instances.

:param keep_days: If specified, only delete records older than the specified number of days.
:returns: The number of deleted instances.
"""
limit = timezone.now()
if keep_days is not None:
limit -= timedelta(days=keep_days)

number, _ = TimelineLog.objects.filter(timestamp__lte=limit).delete()
return number
Loading