Skip to content

Commit

Permalink
Merge pull request #151 from mbeddr/bugfix/fix_jbr_version_download
Browse files Browse the repository at this point in the history
Make downloadJbr accept the distributionType parameter
  • Loading branch information
sergej-koscejev authored Dec 5, 2023
2 parents f359ee2 + 113ec09 commit c3cb3cf
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 7 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 1.21.1

### Fixed

- `downloadJbr` properly accepts the `distributionType` parameter

## 1.21.0

### Added
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ plugins {
id("org.jetbrains.kotlinx.binary-compatibility-validator") version "0.13.2"
}

val baseVersion = "1.21.0"
val baseVersion = "1.21.1"

group = "de.itemis.mps"

Expand Down
14 changes: 8 additions & 6 deletions src/main/kotlin/de/itemis/mps/gradle/downloadJBR/Plugin.kt
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,14 @@ open class DownloadJbrProjectPlugin : Plugin<Project> {
// required for running tests. While a little bit larger than jbr_nomod it should cause the least
// surprises when using it as a default.
// see https://github.com/mbeddr/build.publish.jdk/commit/10bbf7d177336179ca189fc8bb4c1262029c69da
val distributionType = if(extension.distributionType == null &&
Regex("""11_0_[0-9][^0-9]""").find(version) != null) {
"jbr"
} else {
"jbr_jcef"
}
val distributionType =
if (extension.distributionType != null) {
extension.distributionType
} else if (Regex("""11_0_[0-9][^0-9]""").find(version) != null) {
"jbr"
} else {
"jbr_jcef"
}

val cpuArch = when(System.getProperty ("os.arch")) {
"aarch64" -> "aarch64"
Expand Down

0 comments on commit c3cb3cf

Please sign in to comment.