Auto delete service bus by default if the service bus is auto-generated. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this addresses #136 in the fairest way: if the service bus is autoprovisioned, delete will default to remove the service bus. If not, it will stay (of course, this can be overridden by the optional parameter).
This is how Brisk used to work - if the asset was auto-generated it was deprovisioned as well. We could consider doing this with Storage as well but because there's a greater likelihood that they will have some data in them I suggest leaving that default as is - plus there's no cost associated with an empty storage account, unlike a service bus namespace.