Skip to content

Commit

Permalink
feat(ios.LoadingPlaceholder): Accessibility label loading
Browse files Browse the repository at this point in the history
  • Loading branch information
KaylaBrady committed Jan 9, 2025
1 parent bc1de5a commit a45e964
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@
<string name="other_link_source_code">Ver código fuente en GitHub</string>
<string name="other_link_tos">Términos de uso</string>
<string name="outbound">Saliente</string>
<string name="recently_viewed">Visto recientemente</string>
<string name="refresh">Refrescar</string>
<string name="refresh_predictions">Refrescar predicciones</string>
<string name="reload_data">Recargar datos</string>
<string name="recently_viewed">Visto recientemente</string>
<string name="resources_link_fare_info">Información de tarifas</string>
<string name="resources_link_mticket">Boletos de tren de cercanías y ferri</string>
<string name="resources_link_mticket_note">mTicket App</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@
<string name="other_link_source_code">Gade sous sou GitHub</string>
<string name="other_link_tos">Kondisyon itilizasyon</string>
<string name="outbound">Soti</string>
<string name="recently_viewed">Sa w fenk sot Wè</string>
<string name="refresh">Rafrechi</string>
<string name="refresh_predictions">Rafrechi prediksyon</string>
<string name="reload_data">Rechaje done</string>
<string name="recently_viewed">Sa w fenk sot Wè</string>
<string name="resources_link_fare_info">Enfòmasyon Tarif</string>
<string name="resources_link_mticket">Tikè Tren Vil la ak Bato</string>
<string name="resources_link_mticket_note">Aplikasyon mTicket</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@
<string name="other_link_source_code">Exibir origem no GitHub</string>
<string name="other_link_tos">Termos de Uso</string>
<string name="outbound">Saída</string>
<string name="recently_viewed">Visto(s) recentemente</string>
<string name="refresh">Atualizar</string>
<string name="refresh_predictions">Atualizar previsões</string>
<string name="reload_data">Recarregar dados</string>
<string name="recently_viewed">Visto(s) recentemente</string>
<string name="resources_link_fare_info">Informações sobre tarifas</string>
<string name="resources_link_mticket">Bilhetes de transporte diário por trem e balsa</string>
<string name="resources_link_mticket_note">Aplicativo mTicket</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@
<string name="other_link_source_code">Xem nguồn trên GitHub</string>
<string name="other_link_tos">Điều khoản sử dụng</string>
<string name="outbound">Đi</string>
<string name="recently_viewed">Đã xem gần đây</string>
<string name="refresh">Làm mới</string>
<string name="refresh_predictions">Làm mới dự đoán</string>
<string name="reload_data">Tải lại dữ liệu</string>
<string name="recently_viewed">Đã xem gần đây</string>
<string name="resources_link_fare_info">Thông tin giá vé</string>
<string name="resources_link_mticket">Vé phà vé đường sắt ngoại ô (Commuter Rail)</string>
<string name="resources_link_mticket_note">Ứng dụng mTicket</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@
<string name="other_link_source_code">在GitHub上查看源代码</string>
<string name="other_link_tos">使用条款</string>
<string name="outbound">出站</string>
<string name="recently_viewed">近期查看过</string>
<string name="refresh">刷新</string>
<string name="refresh_predictions">刷新预测</string>
<string name="reload_data">重新加载数据</string>
<string name="recently_viewed">近期查看过</string>
<string name="resources_link_fare_info">票价信息</string>
<string name="resources_link_mticket">通勤列车和轮渡票</string>
<string name="resources_link_mticket_note">mTicket应用程序</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@
<string name="other_link_source_code">在GitHub上查看原始程式碼</string>
<string name="other_link_tos">使用條款</string>
<string name="outbound">出站</string>
<string name="recently_viewed">近期查看過</string>
<string name="refresh">重新整理</string>
<string name="refresh_predictions">重新整理預測</string>
<string name="reload_data">重新載入資料</string>
<string name="recently_viewed">近期查看過</string>
<string name="resources_link_fare_info">票價資訊</string>
<string name="resources_link_mticket">通勤列車和輪渡票</string>
<string name="resources_link_mticket_note">mTicket應用程式</string>
Expand Down
16 changes: 8 additions & 8 deletions androidApp/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<string name="detour">Detour</string>
<string name="directionTo">%1$s to</string>
<string name="eastbound">Eastbound</string>
<string name="error_loading_data">Error loading data</string>
<string name="feature_flag_debug_mode">Debug Mode</string>
<string name="feature_flag_route_search">Route Search</string>
<string name="feedback_link_form">Send app feedback</string>
Expand Down Expand Up @@ -65,6 +66,9 @@
<string name="outbound">Outbound</string>
<string name="recenter" tools:ignore="MissingTranslation">Recenter</string>
<string name="recently_viewed">Recently Viewed</string>
<string name="refresh">Refresh</string>
<string name="refresh_predictions">Refresh predictions</string>
<string name="reload_data">Reload data</string>
<string name="resources_link_fare_info">Fare Information</string>
<string name="resources_link_mticket">Commuter Rail and Ferry tickets</string>
<string name="resources_link_mticket_note">mTicket App</string>
Expand All @@ -78,10 +82,14 @@
<string name="star_route">Star route</string>
<string name="star_route_hint">pin route to the top of the list</string>
<string name="stop_closed">Stop Closed</string>
<string name="stop_filter_pills_filter_hint">Apply a filter so that only arrivals from this route are displayed</string>
<string name="stop_filter_pills_remove_hint">Remove the filter and display all routes</string>
<string name="suspension">Suspension</string>
<string name="train">train</string>
<string name="trains">trains</string>
<string name="unable_to_connect">Unable to connect</string>
<string name="unstar_route_hint">unpin route from the top of the list</string>
<string name="updated_mins_ago" tools:ignore="MissingTranslation">Updated %1$d minutes ago</string>
<string name="vehicle_arriving_first">%1$s arriving now</string>
<string name="vehicle_arriving_other">and arriving now</string>
<string name="vehicle_boarding_first">%1$s boarding now</string>
Expand All @@ -97,12 +105,4 @@
<string name="vehicle_schedule_time_first">%1$s arriving at %2$s scheduled</string>
<string name="vehicle_schedule_time_other">and at %1$s scheduled</string>
<string name="westbound">Westbound</string>
<string name="stop_filter_pills_filter_hint">Apply a filter so that only arrivals from this route are displayed</string>
<string name="stop_filter_pills_remove_hint">Remove the filter and display all routes</string>
<string name="refresh">Refresh</string>
<string name="refresh_predictions">Refresh predictions</string>
<string name="updated_mins_ago" tools:ignore="MissingTranslation">Updated %1$d minutes ago</string>
<string name="unable_to_connect">Unable to connect</string>
<string name="reload_data">Reload data</string>
<string name="error_loading_data">Error loading data</string>
</resources>
7 changes: 6 additions & 1 deletion iosApp/iosApp/Utils/LoadingPlaceholderModifier.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ import SwiftUI

struct LoadingPlaceholderModifier: ViewModifier {
func body(content: Content) -> some View {
content.redacted(reason: .placeholder).shimmering().allowsHitTesting(false)
content
.redacted(reason: .placeholder)
.shimmering()
.allowsHitTesting(false)
.accessibilityElement(children: .ignore)
.accessibilityLabel("Loading...")
}
}

Expand Down

0 comments on commit a45e964

Please sign in to comment.