refactor(android.NearbyTransitPage): navigation refactor to support trip filter #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTR
approved these changes
Jan 15, 2025
| } | ||
|
|
||
| fun setStopDetailsDepartures(departures: StopDetailsDepartures?) { | ||
| _stopDetailsDepartures.value = departures | ||
| } | ||
|
|
||
| // TODO: Move these to separate Navigation utils helper |
There was a problem hiding this comment.
Is this something you meant to do or something we should revisit?
There was a problem hiding this comment.
Ah thanks, I had meant to do this as part of this PR, but may leave it in place for now until I port over more of the navigation logic and see how it all fits together.
KaylaBrady
force-pushed
the
kb-android-trip-details-barebones
branch
from
17d504c to
08171ca
Compare
4 tasks
KaylaBrady
force-pushed
the
kb-android-trip-details-barebones
branch
from
08171ca to
4436968
Compare
KaylaBrady
force-pushed
the
kb-android-trip-details-barebones
branch
from
a96d9d8 to
6345929
Compare
|
Accidentally overwrote merging #661 into this branch with a force-push. Manually re-applied merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | stop + trip details | barebones UX
What is this PR for?
This is a first step in getting the barebones UX trip details.
SheetRouteinstead ofNavBackStackEntry. This made it easier to read the filters that are set on the stop details pages.setStopFilterlogic from iOS.iOS
android
withContext(Dispatchers.Default)where possibleTesting
What testing have you done?