Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(StopDetailsPage): Pull data into VM #661

Merged
merged 9 commits into from
Jan 21, 2025
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package com.mbta.tid.mbta_app.android

import com.mbta.tid.mbta_app.model.StopDetailsFilter
import junit.framework.TestCase.assertFalse
import kotlin.test.assertTrue
import org.junit.Test

class SheetRouteTest {
@Test
fun testPageChangedNearbyToStopDetails() {
assertTrue(
SheetRoutes.pageChanged(
SheetRoutes.NearbyTransit,
SheetRoutes.StopDetails("a", null, null)
)
)
}

@Test
fun testPageChangedWhenStopDetailsDifferentStops() {
assertTrue(
SheetRoutes.pageChanged(
SheetRoutes.StopDetails("a", null, null),
SheetRoutes.StopDetails("b", null, null)
)
)
}

@Test
fun testPageNotChangedWhenStopDetailsSameStopDifferentFilters() {
assertFalse(
SheetRoutes.pageChanged(
SheetRoutes.StopDetails("a", null, null),
SheetRoutes.StopDetails("a", StopDetailsFilter("route1", 1), null)
)
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import com.mbta.tid.mbta_app.android.location.ViewportProvider
import com.mbta.tid.mbta_app.android.map.IMapViewModel
import com.mbta.tid.mbta_app.android.pages.NearbyTransit
import com.mbta.tid.mbta_app.android.pages.NearbyTransitPage
import com.mbta.tid.mbta_app.android.stopDetails.StopDetailsViewModel
import com.mbta.tid.mbta_app.android.util.LocalActivity
import com.mbta.tid.mbta_app.android.util.LocalLocationClient
import com.mbta.tid.mbta_app.map.RouteLineData
Expand Down Expand Up @@ -74,8 +75,8 @@ import kotlinx.datetime.Clock
import kotlinx.datetime.Instant
import org.junit.Rule
import org.junit.Test
import org.koin.androidx.viewmodel.dsl.viewModelOf
import org.koin.compose.KoinContext
import org.koin.core.module.dsl.*
import org.koin.dsl.koinApplication
import org.koin.dsl.module
import org.koin.test.KoinTest
Expand Down Expand Up @@ -271,6 +272,7 @@ class NearbyTransitPageTest : KoinTest {
single<IVehiclesRepository> { MockVehiclesRepository() }
single<ISearchResultRepository> { MockSearchResultRepository() }
viewModelOf(::NearbyTransitViewModel)
viewModelOf(::StopDetailsViewModel)
single<IVisitHistoryRepository> { MockVisitHistoryRepository() }
single<VisitHistoryUsecase> { VisitHistoryUsecase(get()) }
}
Expand Down
Loading
Loading