Onboarding ui for android #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackVCurtis
force-pushed
the
jvc-android-onboarding-ui
branch
2 times, most recently
from
bbd0db9 to
3f2c73c
Compare
BrandonTR
reviewed
Jan 22, 2025
| Column( | ||
| verticalArrangement = Arrangement.spacedBy(16.dp), | ||
| horizontalAlignment = Alignment.Start | ||
| Box( |
There was a problem hiding this comment.
Would it be a significant amount of work to split the screens into their own file? If we have to pass around too many params I'm fine with punting on this.
There was a problem hiding this comment.
Yeah, I felt the same way but opted to follow the example in the existing iOS code. I'm down to change things though.
Thank you for testing, I thought I had the resource but must have missed something |
BrandonTR
approved these changes
Jan 22, 2025
JackVCurtis
force-pushed
the
jvc-android-onboarding-ui
branch
from
98636e8 to
12d9c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Onboarding Flow UI
What is this PR for?
Updates the Onboarding Flow to look like the designs.
(Highlighting is due to the Android voice accessibility interface)
iOS
android
withContext(Dispatchers.Default)where possibleTesting
What testing have you done?
Manual testing for display.