fix(Android): Make entire more page rows tappable #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
androidApp/src/main/java/com/mbta/tid/mbta_app/android/more/MoreLink.kt
Outdated
Show resolved
Hide resolved
boringcactus
approved these changes
Jan 21, 2025
EmmaSimon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: [fix: more tab links]
Previously, only the text on the more page links was tappable, tapping on the empty space or icon in the row didn't do anything. This switches to a different method for opening links and phone numbers. It also includes the padding around the toggle rows in the tappable/animated area.
android
- [ ] All user-facing strings added to strings resource- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Verified that links still behave as expected, and are tappable along the entire row.